Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Skip creating partition rate limiters when not enable #38816

Merged
merged 8 commits into from
Jan 23, 2025
Merged

enhance: Skip creating partition rate limiters when not enable #38816

merged 8 commits into from
Jan 23, 2025

Conversation

bigsheeper
Copy link
Contributor

issue: #37630

@bigsheeper bigsheeper mentioned this pull request Dec 27, 2024
Merged
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 27, 2024
@sre-ci-robot sre-ci-robot requested review from czs007 and yhmo December 27, 2024 09:17
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 27, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 27, 2024

@bigsheeper cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@bigsheeper bigsheeper mentioned this pull request Dec 27, 2024
Open
41 tasks
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 27, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper bigsheeper added the 10kcp PR related to 10k collection partitions Project label Dec 30, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 30, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Dec 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (fd84ed8) to head (4cbf46c).
Report is 78 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38816       +/-   ##
===========================================
+ Coverage   69.71%   81.16%   +11.44%     
===========================================
  Files         299     1404     +1105     
  Lines       26768   197720   +170952     
===========================================
+ Hits        18661   160474   +141813     
- Misses       8107    31627    +23520     
- Partials        0     5619     +5619
Components Coverage Δ
Client 79.53% <ø> (∅)
Core 69.71% <ø> (ø)
Go 83.09% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/rootcoord/quota_center.go 83.25% <100.00%> (ø)

... and 1104 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 1, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

@bigsheeper bigsheeper mentioned this pull request Jan 1, 2025
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 1, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

This was referenced Jan 1, 2025
Merged
Open
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 9, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 9, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

@SimFG
Copy link
Contributor

SimFG commented Jan 9, 2025

/lgtm

@mergify mergify bot added the ci-passed label Jan 9, 2025
@sre-ci-robot sre-ci-robot removed the lgtm label Jan 14, 2025
@mergify mergify bot removed the ci-passed label Jan 14, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 14, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@czs007 czs007 assigned liliu-z and unassigned SimFG Jan 14, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 14, 2025

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 15, 2025

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 15, 2025

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

sre-ci-robot pushed a commit that referenced this pull request Jan 15, 2025
@bigsheeper
enhance: [2.5] Skip creating partition rate limiters when not enable (#…
9b916f2 
…38911)

issue: #37630

pr: #38816

---------

Signed-off-by: bigsheeper <[email protected]>
@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 16, 2025
@czs007
Copy link
Collaborator

czs007 commented Jan 23, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 154edd2 into milvus-io:master Jan 23, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liliu-z liliu-z liliu-z left review comments

@czs007 czs007 Awaiting requested review from czs007

@yhmo yhmo Awaiting requested review from yhmo

Assignees

@czs007 czs007

@liliu-z liliu-z

Labels
10kcp PR related to 10k collection partitions Project approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bigsheeper @SimFG @czs007 @sre-ci-robot @liliu-z