Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: unmashall ts msg in dispatcher instead in msgstream #38656

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

fix dispatcher

ec7ee1b
Select commit
Loading
Failed to load commit list.
Open

enhance: unmashall ts msg in dispatcher instead in msgstream #38656

fix dispatcher
ec7ee1b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 16, 2025 in 0s

81.01% (target 77.00%)

View this Pull Request on Codecov

81.01% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 69.73294% with 102 lines in your changes missing coverage. Please review.

Project coverage is 81.01%. Comparing base (bca2a62) to head (ec7ee1b).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
pkg/mq/msgstream/msgstream.go 59.65% 59 Missing and 12 partials ⚠️
pkg/mq/msgstream/mq_msgstream.go 83.95% 12 Missing and 1 partial ⚠️
pkg/mq/msgdispatcher/dispatcher.go 78.57% 4 Missing and 2 partials ⚠️
internal/querynodev2/delegator/delegator_data.go 50.00% 2 Missing and 1 partial ⚠️
pkg/mq/msgstream/msgstream_util.go 85.00% 2 Missing and 1 partial ⚠️
pkg/mq/msgstream/trace.go 40.00% 3 Missing ⚠️
pkg/mq/msgstream/msg.go 90.00% 2 Missing ⚠️
pkg/mq/msgstream/wasted_mock_msgstream.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38656       +/-   ##
===========================================
+ Coverage   69.63%   81.01%   +11.37%     
===========================================
  Files         299     1407     +1108     
  Lines       26807   198757   +171950     
===========================================
+ Hits        18668   161019   +142351     
- Misses       8139    32077    +23938     
- Partials        0     5661     +5661     
Components Coverage Δ
Client 79.50% <ø> (∅)
Core 69.48% <ø> (-0.16%) ⬇️
Go 82.94% <69.73%> (∅)
Files with missing lines Coverage Δ
pkg/mq/common/message.go 38.09% <ø> (ø)
pkg/mq/msgstream/wasted_mock_msgstream.go 75.00% <0.00%> (ø)
pkg/mq/msgstream/msg.go 80.72% <90.00%> (ø)
internal/querynodev2/delegator/delegator_data.go 84.51% <50.00%> (ø)
pkg/mq/msgstream/msgstream_util.go 56.86% <85.00%> (ø)
pkg/mq/msgstream/trace.go 61.90% <40.00%> (ø)
pkg/mq/msgdispatcher/dispatcher.go 90.32% <78.57%> (ø)
pkg/mq/msgstream/mq_msgstream.go 79.03% <83.95%> (ø)
pkg/mq/msgstream/msgstream.go 65.36% <59.65%> (ø)

... and 1112 files with indirect coverage changes