Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: unmashall ts msg in dispatcher instead in msgstream #38656

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Dec 23, 2024

relate: #38655

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aoiasd
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Dec 23, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 23, 2024
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Dec 23, 2024
Copy link
Contributor

mergify bot commented Dec 23, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 23, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 23, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 69.73294% with 102 lines in your changes missing coverage. Please review.

Project coverage is 81.01%. Comparing base (bca2a62) to head (ec7ee1b).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
pkg/mq/msgstream/msgstream.go 59.65% 59 Missing and 12 partials ⚠️
pkg/mq/msgstream/mq_msgstream.go 83.95% 12 Missing and 1 partial ⚠️
pkg/mq/msgdispatcher/dispatcher.go 78.57% 4 Missing and 2 partials ⚠️
internal/querynodev2/delegator/delegator_data.go 50.00% 2 Missing and 1 partial ⚠️
pkg/mq/msgstream/msgstream_util.go 85.00% 2 Missing and 1 partial ⚠️
pkg/mq/msgstream/trace.go 40.00% 3 Missing ⚠️
pkg/mq/msgstream/msg.go 90.00% 2 Missing ⚠️
pkg/mq/msgstream/wasted_mock_msgstream.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38656       +/-   ##
===========================================
+ Coverage   69.63%   81.01%   +11.37%     
===========================================
  Files         299     1407     +1108     
  Lines       26807   198757   +171950     
===========================================
+ Hits        18668   161019   +142351     
- Misses       8139    32077    +23938     
- Partials        0     5661     +5661     
Components Coverage Δ
Client 79.50% <ø> (∅)
Core 69.48% <ø> (-0.16%) ⬇️
Go 82.94% <69.73%> (∅)
Files with missing lines Coverage Δ
pkg/mq/common/message.go 38.09% <ø> (ø)
pkg/mq/msgstream/wasted_mock_msgstream.go 75.00% <0.00%> (ø)
pkg/mq/msgstream/msg.go 80.72% <90.00%> (ø)
internal/querynodev2/delegator/delegator_data.go 84.51% <50.00%> (ø)
pkg/mq/msgstream/msgstream_util.go 56.86% <85.00%> (ø)
pkg/mq/msgstream/trace.go 61.90% <40.00%> (ø)
pkg/mq/msgdispatcher/dispatcher.go 90.32% <78.57%> (ø)
pkg/mq/msgstream/mq_msgstream.go 79.03% <83.95%> (ø)
pkg/mq/msgstream/msgstream.go 65.36% <59.65%> (ø)

... and 1112 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Dec 24, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 24, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 14, 2025

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 16, 2025

@aoiasd cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 16, 2025

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 16, 2025

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Jan 16, 2025

rerun cpp-unit-test

@aoiasd
Copy link
Contributor Author

aoiasd commented Jan 16, 2025

/run-cpu-e2e

@aoiasd
Copy link
Contributor Author

aoiasd commented Jan 16, 2025

rerun go-sdk

@mergify mergify bot added the ci-passed label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants