enhance: catch std::stoi exception and improve error msg #36296
Merged
Codecov / codecov/project
succeeded
Sep 18, 2024 in 1s
81.09% (target 77.00%)
View this Pull Request on Codecov
81.09% (target 77.00%)
Details
Codecov Report
Attention: Patch coverage is 41.17647% with 20 lines in your changes missing coverage. Please review.
Project coverage is 81.09%. Comparing base (
1cd8d1b) to head (32e4cba).
Report is 20 commits behind head on 2.4.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| internal/core/src/index/Utils.cpp | 28.57% | 10 Missing |
| internal/core/src/storage/DiskFileManagerImpl.cpp | 50.00% | 10 Missing |
Additional details and impacted files
@@ Coverage Diff @@
## 2.4 #36296 +/- ##
==========================================
- Coverage 81.15% 81.09% -0.07%
==========================================
Files 1059 1060 +1
Lines 139498 139625 +127
==========================================
+ Hits 113214 113231 +17
- Misses 22007 22101 +94
- Partials 4277 4293 +16 | Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/core/src/index/Utils.cpp | 36.51% <28.57%> (-1.44%) |
⬇️ |
| internal/core/src/storage/DiskFileManagerImpl.cpp | 66.26% <50.00%> (-1.09%) |
⬇️ |
Loading