Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: catch std::stoi exception and improve error msg #36296

Merged
merged 1 commit into from
Sep 18, 2024

enhance: catch std::stoi exception and improve error msg

32e4cba
Select commit
Loading
Failed to load commit list.
Merged

enhance: catch std::stoi exception and improve error msg #36296

enhance: catch std::stoi exception and improve error msg
32e4cba
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Sep 18, 2024 in 0s

41.17% of diff hit (target 80.00%)

View this Pull Request on Codecov

41.17% of diff hit (target 80.00%)

Annotations

Check warning on line 137 in internal/core/src/index/Utils.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/core/src/index/Utils.cpp#L133-L137 

Added lines #L133 - L137 were not covered by tests

Check warning on line 164 in internal/core/src/index/Utils.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/core/src/index/Utils.cpp#L163-L164 

Added lines #L163 - L164 were not covered by tests

Check warning on line 169 in internal/core/src/index/Utils.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/core/src/index/Utils.cpp#L167-L169 

Added lines #L167 - L169 were not covered by tests

Check warning on line 248 in internal/core/src/storage/DiskFileManagerImpl.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/core/src/storage/DiskFileManagerImpl.cpp#L244-L248 

Added lines #L244 - L248 were not covered by tests

Check warning on line 311 in internal/core/src/storage/DiskFileManagerImpl.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/core/src/storage/DiskFileManagerImpl.cpp#L307-L311 

Added lines #L307 - L311 were not covered by tests
View more details on Codecov