Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OD Explanation Loader Fix #2381

Merged
merged 7 commits into from
Oct 26, 2023
Merged

OD Explanation Loader Fix #2381

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8f225b4
ckpt
Advitya17 Oct 2, 2023
8f802f3
Merge branch 'main' into agemawat/loader_fix
Advitya17 Oct 2, 2023
4b5e516
ternary condition fix
Advitya17 Oct 3, 2023
a4dfa58
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
Advitya17 Oct 3, 2023
976e611
auto lint fixes
Advitya17 Oct 3, 2023
ffeaebe
Merge branch 'main' into agemawat/loader_fix
Advitya17 Oct 4, 2023
2b45bc7
Merge branch 'main' into agemawat/loader_fix
Advitya17 Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/FlyoutObjectDetection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ export class FlyoutObjectDetection extends React.Component<
+this.state.odSelectedKey.slice(
FlyoutODUtils.ExcessLabelLen
)
] ? (
] && (
<FluentUI.Stack.Item className={classNames.imageContainer}>
<FluentUI.Image
src={`data:image/jpg;base64,${this.props.explanations
Expand All @@ -212,13 +212,21 @@ export class FlyoutObjectDetection extends React.Component<
style={explanationImage}
/>
</FluentUI.Stack.Item>
) : (
<FluentUI.Stack.Item>
<FluentUI.Spinner
label={`${localization.InterpretVision.Dashboard.loading} ${item?.index}`}
/>
</FluentUI.Stack.Item>
)}
{this.state.odSelectedKey !== "" &&
this.props.loadingExplanation[item.index][
+this.state.odSelectedKey.slice(
FlyoutODUtils.ExcessLabelLen
)
] && (
<FluentUI.Stack.Item>
<FluentUI.Spinner
label={`${localization.InterpretVision.Dashboard.loading} ${
item?.index
}`}
/>
</FluentUI.Stack.Item>
)}
</FluentUI.Stack>
</FluentUI.Stack>
</FluentUI.Stack>
Expand Down
2 changes: 1 addition & 1 deletion libs/localization/src/lib/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1449,7 +1449,7 @@
"labelVisibilityDropdown": "Select labels to display",
"legendFailure": "failure",
"legendSuccess": "success",
"loading": "Computing explanation for index",
"loading": "Computing explanation for image of index",
"multiselect": "Multiselect",
"notdefined": "object scenario not defined",
"objectSelect": "Object Selection",
Expand Down