OD Explanation Loader Fix #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Advitya17
force-pushed
the
agemawat/loader_fix
branch
from
a3f6387 to
8f802f3
Compare
1 similar comment
Advitya17
requested review from
imatiach-msft,
gaugup,
tongyu-microsoft,
xuke444,
RubyZ10,
vinuthakaranth and
hawestra
as code owners
…olbox into agemawat/loader_fix
romanlutz
approved these changes
Oct 3, 2023
gaugup
approved these changes
Oct 3, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initially, the loader was shown on the OD Flyout even when no detection was selected to compute explanations for.
Now, the loader is only displayed when the user selects a detection:
Checklist