fileinfo: internally fix FileBasicInfo memory alignment #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Davis Goodin <[email protected]>
6 tasks
helsaawy
approved these changes
Jan 16, 2024
Remove unused winName. Extract more into Windows alignment consts to repeat less. Document reason for having multiple alignment consts for the same value. Signed-off-by: Davis Goodin <[email protected]>
dagood
force-pushed
the
dev/dagood/align-fileinfo
branch
from
f9a3551 to
2a888ac
Compare
This was referenced May 20, 2024
kiashok
pushed a commit
to kiashok/go-winio
that referenced
this pull request
May 21, 2024
* fileinfo: internally fix FileBasicInfo memory alignment Signed-off-by: Davis Goodin <[email protected]> * Update test with review feedback Remove unused winName. Extract more into Windows alignment consts to repeat less. Document reason for having multiple alignment consts for the same value. Signed-off-by: Davis Goodin <[email protected]> --------- Signed-off-by: Davis Goodin <[email protected]> (cherry picked from commit 008bc6e) Signed-off-by: Kirtana Ashok <[email protected]>
kiashok
pushed a commit
to kiashok/go-winio
that referenced
this pull request
May 21, 2024
* fileinfo: internally fix FileBasicInfo memory alignment Signed-off-by: Davis Goodin <[email protected]> * Update test with review feedback Remove unused winName. Extract more into Windows alignment consts to repeat less. Document reason for having multiple alignment consts for the same value. Signed-off-by: Davis Goodin <[email protected]> --------- Signed-off-by: Davis Goodin <[email protected]> (cherry picked from commit 008bc6e) Signed-off-by: Kirtana Ashok <[email protected]>
kiashok
pushed a commit
to kiashok/go-winio
that referenced
this pull request
May 21, 2024
* fileinfo: internally fix FileBasicInfo memory alignment Signed-off-by: Davis Goodin <[email protected]> * Update test with review feedback Remove unused winName. Extract more into Windows alignment consts to repeat less. Document reason for having multiple alignment consts for the same value. Signed-off-by: Davis Goodin <[email protected]> --------- Signed-off-by: Davis Goodin <[email protected]> (cherry picked from commit 008bc6e) Signed-off-by: Kirtana Ashok <[email protected]>
kiashok
pushed a commit
that referenced
this pull request
May 21, 2024
* fileinfo: internally fix FileBasicInfo memory alignment Signed-off-by: Davis Goodin <[email protected]> * Update test with review feedback Remove unused winName. Extract more into Windows alignment consts to repeat less. Document reason for having multiple alignment consts for the same value. Signed-off-by: Davis Goodin <[email protected]> --------- Signed-off-by: Davis Goodin <[email protected]> (cherry picked from commit 008bc6e) Signed-off-by: Kirtana Ashok <[email protected]>
kiashok
pushed a commit
to kiashok/go-winio
that referenced
this pull request
May 21, 2024
* fileinfo: internally fix FileBasicInfo memory alignment Signed-off-by: Davis Goodin <[email protected]> * Update test with review feedback Remove unused winName. Extract more into Windows alignment consts to repeat less. Document reason for having multiple alignment consts for the same value. Signed-off-by: Davis Goodin <[email protected]> --------- Signed-off-by: Davis Goodin <[email protected]> (cherry picked from commit 008bc6e) Signed-off-by: Kirtana Ashok <[email protected]>
kiashok
pushed a commit
that referenced
this pull request
May 21, 2024
* fileinfo: internally fix FileBasicInfo memory alignment Signed-off-by: Davis Goodin <[email protected]> * Update test with review feedback Remove unused winName. Extract more into Windows alignment consts to repeat less. Document reason for having multiple alignment consts for the same value. Signed-off-by: Davis Goodin <[email protected]> --------- Signed-off-by: Davis Goodin <[email protected]> (cherry picked from commit 008bc6e) Signed-off-by: Kirtana Ashok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileBasicInfoalignment is incorrect, leading towinio.SetFileBasicInforeturning "Invalid access to memory location." #311This PR fixes memory alignment for the structs passed to both
GetFileInformationByHandleExandSetFileInformationByHandle.Includes a direct test for memory alignment. (Also makes sure it has the right amount of padding, since it's convenient to check this in the test too.)