Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang to v1.22 in CI #1387

Merged
merged 1 commit into from
May 23, 2024

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Update the go version used in CI to the latest minor release.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 28, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 28, 2024
@kwilczynski
Copy link
Member

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

@kwilczynski: changing LGTM is restricted to collaborators

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kannon92
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2024
@saschagrunert
Copy link
Member Author

Hm, this seems to break the windows CI. 🧐

@kwilczynski
Copy link
Member

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

@kwilczynski: changing LGTM is restricted to collaborators

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kwilczynski
Copy link
Member

@saschagrunert, I wonder if we can poke these Windows-centric tests again, to see how things look afresh.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2024
@saschagrunert
Copy link
Member Author

Gave it a rebase.

Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 15, 2024
@saschagrunert saschagrunert force-pushed the go-1.22 branch 3 times, most recently from dacfd29 to 6e45625 Compare May 15, 2024 07:09
@saschagrunert saschagrunert force-pushed the go-1.22 branch 3 times, most recently from e0275c0 to 6f4e9ab Compare May 15, 2024 07:24
Signed-off-by: Sascha Grunert <[email protected]>
@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented May 17, 2024

/lgtm

Do you think the test failure related to this change?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024
@mikebrow
Copy link
Contributor

Reads like the windows pause container has a bad missing layer... [FAILED] failed to create PodSandbox: rpc error: code = Unknown desc = failed to get sandbox image "registry.k8s.io/pause:3.8": failed to pull image "registry.k8s.io/pause:3.8": failed to pull and unpack image "registry.k8s.io/pause:3.8": failed to extract layer sha256:5ad177daa048ca8b354b9ad03deac863ff519a2860a35dc9fdc0011619aacc3c: SetFileInformationByHandle \\?\C:\Users\RUNNER~1\AppData\Local\Temp\hcs1803373873\Files.$wcidirs$: Invalid access to memory location.: unknown

@cpuguy83
Copy link

cpuguy83 commented May 20, 2024

@mikebrow
Copy link
Contributor

@saschagrunert could you re-run these testbuckets, microsoft team believes they have fixed 1.7 5days back right here containerd/containerd#10232 and are working on 1.6 update for the golang changes.

@mikebrow
Copy link
Contributor

fixes have been merged .. these containerd buckets should pass pls restart.

@cpuguy83
Copy link

Can someone re-trigger the tests?
I believe the failures should work without needing to change anything here.

@k8s-ci-robot k8s-ci-robot merged commit ff0ce76 into kubernetes-sigs:master May 23, 2024
23 checks passed
@saschagrunert saschagrunert deleted the go-1.22 branch May 28, 2024 06:58
@saschagrunert
Copy link
Member Author

I assume we're good since other PR's CI passes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants