-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump golang to v1.22 in CI #1387
Conversation
/approve |
@kwilczynski: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
Hm, this seems to break the windows CI. 🧐 |
/approve |
@kwilczynski: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@saschagrunert, I wonder if we can poke these Windows-centric tests again, to see how things look afresh. |
Gave it a rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, saschagrunert, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dacfd29
to
6e45625
Compare
e0275c0
to
6f4e9ab
Compare
Signed-off-by: Sascha Grunert <[email protected]>
/lgtm Do you think the test failure related to this change? |
Reads like the windows pause container has a bad missing layer... |
Error looks like its due to compiling 1.6 and 1.7 with go1.22 with an outdated go-winio.
|
@saschagrunert could you re-run these testbuckets, microsoft team believes they have fixed 1.7 5days back right here containerd/containerd#10232 and are working on 1.6 update for the golang changes. |
fixes have been merged .. these containerd buckets should pass pls restart. |
Can someone re-trigger the tests? |
I assume we're good since other PR's CI passes now. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Update the go version used in CI to the latest minor release.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?