Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[False Positive][False Negative] Outdated/Banned SSL/TLS protocols #649

Merged
merged 6 commits into from
Dec 4, 2024
Merged

[False Positive][False Negative] Outdated/Banned SSL/TLS protocols #649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cc41422
[False Positive][False Negative] Outdated/Banned SSL/TLS protocols
julianladisch Oct 27, 2024
0210dcd
Update Changelog.md
julianladisch Nov 2, 2024
75f2ff9
Merge branch 'main' into ssl-tls-protocols
julianladisch Nov 2, 2024
1cd2291
Merge branch 'main' into ssl-tls-protocols
julianladisch Nov 13, 2024
e6dc068
Put correct version in changelog
gfs Nov 20, 2024
7f9f557
Merge branch 'main' into ssl-tls-protocols
gfs Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.0.49] - 2024-12-03
## Rules
Fixed false positives and false negatives in outdated/banned SSL/TLS protocols. #649

## [1.0.48] - 2024-11-20
### Dependencies
Update VS Code Extension Dependencies
Expand Down
48 changes: 29 additions & 19 deletions rules/default/security/cryptography/protocol.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,17 +82,31 @@
"rule_info": "DS169126.md",
"patterns": [
{
"pattern": "(SSLv?2|SSLv?3|TLSv?1|TLSv?10)",
"pattern": "(SSLv?2|SSLv?3|TLSv?1(?![._]?[2-9])|TLSv?1[._]?[01])",
"type": "RegexWord",
"scopes": [
"code"
]
}
],
"must-match": [
"SSLv2",
"SSLv3",
"TLSv1",
"TLSv10"
"TLSv10",
"TLSv1_0",
"TLSv1.0",
"TLSv11",
"TLSv1_1",
"TLSv1.1"
],
"must-not-match": [
"TLSv12",
"TLSv1_2",
"TLSv1.2",
"TLSv13",
"TLSv1_3",
"TLSv1.3"
]
},
{
Expand Down Expand Up @@ -129,36 +143,32 @@
]
},
{
"pattern": "TLSv1(?!_[2-9])",
"type": "regex",
"scopes": [
"code"
]
},
{
"pattern": "TLSv1(0|_0)",
"pattern": "TLSv1(?![._]?[2-9])",
"type": "regex",
"scopes": [
"code"
]
},
{
"pattern": "TLSv1_1",
"type": "string",
"scopes": [
"code"
]
}
],
"must-match": [
"SSLv3",
"TLSv1",
"TLSv10",
"TLSv1.0",
"TLSv1_0",
"TLSv11",
"TLSv1.1",
"TLSv1_1",
"TLSv1X9",
"SSLv2_client"
],
"must-not-match":[
"TLSv12",
"TLSv1_2",
"TLSv1_3"
"TLSv1.2",
"TLSv13",
"TLSv1_3",
"TLSv1.3"
]
},
{
Expand Down Expand Up @@ -474,4 +484,4 @@
"must-not-match": [
]
}
]
]
Loading