[False Positive][False Negative] Outdated/Banned SSL/TLS protocols #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Rule ID DS169125 Do not use outdated SSL/TLS protocols DS169126 An Outdated or Banned SSL/TLS Protocol is Used ## What the rule matched DS169125 * TLSv1.2 * TLSv1.3 DS169126 * TLSv12 * TLSv1.2 * TLSv13 * TLSv1.3 ## Why should this not be matched? https://github.com/microsoft/DevSkim/blob/v1.0.33/guidance/DS169126.md says: > Use TLSv1.3 if possible or TLSv1.2 if 1.3 cannot be used. ## What the rule did not match (false negative) DS169125 * TLSv1_0 * TLSv11 * TLSv1_1 ## Why should this be matched? https://github.com/microsoft/DevSkim/blob/v1.0.33/guidance/DS169126.md says: >TLSv1 - Weak, strongly consider disabling unless absolutely required. >TLSv1.1 - Weak, strongly consider disabling unless absolutely required. It already matches TLSv10 and TLSv1.0, therefore it should also match TLSv1_0. It already matches TLSv1.1, therefore it should also match TLSv11 and TLSv1_1.
|
@microsoft-github-policy-service agree |
|
Thanks for the contribution, I'll aim to review this this week. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
gfs
approved these changes
Dec 4, 2024
danfiedler-msft
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule ID
DS169125 Do not use outdated SSL/TLS protocols
DS169126 An Outdated or Banned SSL/TLS Protocol is Used
What the rule matched
DS169125
DS169126
Why should this not be matched?
https://github.com/microsoft/DevSkim/blob/v1.0.33/guidance/DS169126.md says:
What the rule did not match (false negative)
DS169125
Why should this be matched?
https://github.com/microsoft/DevSkim/blob/v1.0.33/guidance/DS169126.md says:
It already matches TLSv10 and TLSv1.0, therefore it should also match TLSv1_0. It already matches TLSv1.1, therefore it should also match TLSv11 and TLSv1_1.