Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove abstract slot globally from schema #1055

Merged
merged 4 commits into from
Aug 17, 2023
Merged

Conversation

brynnz22
Copy link
Contributor

@brynnz22 brynnz22 commented Aug 1, 2023

I removed the abstract slot globally from the schema. It was only be used in the Study class and was not used at all in MongoDb. So it does not get confused with the description slot in the future, where it is interchangeable, we are removing it.

@brynnz22 brynnz22 requested a review from turbomam August 1, 2023 15:53
@brynnz22 brynnz22 marked this pull request as ready for review August 2, 2023 20:56
@brynnz22
Copy link
Contributor Author

@turbomam I added an invalid example data file that includes the abstract slot. I think this is good to merge now too.

@turbomam turbomam merged commit baeca64 into main Aug 17, 2023
2 checks passed
@turbomam turbomam deleted the issue340-remove-abstract-slot branch August 17, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants