Skip to content

Commit

Permalink
Merge pull request #1055 from microbiomedata/issue340-remove-abstract…
Browse files Browse the repository at this point in the history
…-slot

remove abstract slot globally from schema
  • Loading branch information
turbomam authored Aug 17, 2023
2 parents b579636 + 0a12975 commit baeca64
Show file tree
Hide file tree
Showing 4 changed files with 85 additions and 9 deletions.
85 changes: 85 additions & 0 deletions src/data/invalid/Study-include-abstract.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
study_set:
- id: nmdc:sty-11-ab
name: see also description, title, objective, various alternatives
abstract: This study is about a thing.
description: see also name, title, objective, various alternatives
alternative_identifiers:
- generic:abc1
related_identifiers: any string R1
#emsl_proposal_identifier:
# - generic:abc1
#emsl_proposal_doi: any string
gold_study_identifiers:
- GOLD:Gs12345
- GOLD:Gs90909
mgnify_project_identifiers:
- mgnify.proj:ABC123
ecosystem: unconstrained text. should be validated against the controlled vocabulary,
by the sample's environmental package. would also be nice to align the CV with MIxS
environmental triads
ecosystem_category: unconstrained text
ecosystem_type: unconstrained text
ecosystem_subtype: unconstrained text
specific_ecosystem: unconstrained text
principal_investigator:
has_raw_value: Craig Venter
was_generated_by: nmdc:any_string_1
orcid: ORCID:0000-0002-7086-765X
profile_image_url: https://en.wikipedia.org/wiki/Craig_Venter#/media/File:Craigventer2.jpg
email: [email protected]
name: J. Craig Venter
websites:
- https://www.jcvi.org/
- https://www.jcvi.org/about/j-craig-venter
title: Sample Exhaustive Biosample instance. Although all of these values should pass
validation, that does not mean that any Biosample of any type would necessarily
have this particular combination of values.
alternative_titles:
- any string 1
- any string 2
alternative_descriptions:
- any string 1
- any string 2
alternative_names:
- any string 1
- any string 2
objective: This record, an instance of class Study from the nmdc-schema was had authored,
so that the NMDC team would have at least one instance, using all slots, with a
mixture of reasonable values and minimally compliant values.
websites:
- https://w3id.org/nmdc
- https://w3id.org/linkml
publications:
- any string 1
- any string 2
ess_dive_datasets:
- any string 1
- any string 2
type: any string
relevant_protocols:
- any string 1
- any string 2
funding_sources:
- any string 1
- any string 2
has_credit_associations:
- applies_to_person:
has_raw_value: Craig Venter
was_generated_by: nmdc:any_string_1
orcid: ORCID:0000-0002-7086-765X
profile_image_url: https://en.wikipedia.org/wiki/Craig_Venter#/media/File:Craigventer2.jpg
email: [email protected]
name: J. Craig Venter
websites:
- https://www.jcvi.org/
- https://www.jcvi.org/about/j-craig-venter
applied_roles:
- Supervision
- Conceptualization
applied_role: Funding acquisition
type: any string
- applies_to_person:
name: Tanja Davidsen
applied_roles:
- Investigation
- Supervision
1 change: 0 additions & 1 deletion src/data/valid/Study-exhaustive.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ alternative_descriptions:
alternative_names:
- any string 1
- any string 2
abstract: Nothing was studied.
objective: This record, an instance of class Study from the nmdc-schema was had authored,
so that the NMDC team would have at least one instance, using all slots, with a
mixture of reasonable values and minimally compliant values.
Expand Down
7 changes: 0 additions & 7 deletions src/schema/core.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -683,13 +683,6 @@ slots:
range: string
description: >-
MD5 checksum of file (pre-compressed)
abstract:
range: string
description: >-
The abstract of manuscript/grant associated with the entity; i.e., a summary of the resource.
exact_mappings:
- dcterms:abstract
keywords:
range: string
Expand Down
1 change: 0 additions & 1 deletion src/schema/nmdc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1344,7 +1344,6 @@ classes:
## Related IDs
#- insdc_bioproject_identifiers
#- insdc_sra_ena_study_identifiers
- abstract
- alternative_descriptions
- alternative_names
- alternative_titles
Expand Down

0 comments on commit baeca64

Please sign in to comment.