Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1183 apiproxy subpaths matching fix #1185

Merged
merged 6 commits into from
Jul 17, 2024

Conversation

predic8
Copy link
Member

@predic8 predic8 commented Jul 12, 2024

No description provided.

@predic8 predic8 requested a review from rrayst July 12, 2024 11:46
…g-fix

# Conflicts:
#	core/src/main/java/com/predic8/membrane/core/rules/ServiceProxyKey.java
@rrayst
Copy link
Contributor

rrayst commented Jul 17, 2024

@predic8 why doesn't the 'test' condition go through LanguageSupport?

All Spel Expressions (as currently implemented in the master branch and suggested by this pull request) are always interpreted.

Adding these expressions to a rule key causes a slow down in all incoming requests.

Allowing the user to switch to Groovy would therefore increase performance significantly.

@christiangoerdes christiangoerdes merged commit 2ca6a57 into master Jul 17, 2024
3 checks passed
@christiangoerdes christiangoerdes deleted the #1183-apiproxy-subpaths-matching-fix branch July 17, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants