Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why doesn't the 'test' condition go through LanguageSupport? #1199

Closed
rrayst opened this issue Jul 17, 2024 · 2 comments · Fixed by #1223
Closed

why doesn't the 'test' condition go through LanguageSupport? #1199

rrayst opened this issue Jul 17, 2024 · 2 comments · Fixed by #1223
Assignees

Comments

@rrayst
Copy link
Contributor

rrayst commented Jul 17, 2024

@predic8 why doesn't the 'test' condition go through LanguageSupport?

All Spel Expressions (as currently implemented in the master branch and suggested by this pull request) are always interpreted.

Adding these expressions to a rule key causes a slow down in all incoming requests.

Allowing the user to switch to Groovy would therefore increase performance significantly.

Originally posted by @rrayst in #1185 (comment)

@t-burch
Copy link
Collaborator

t-burch commented Jul 29, 2024

@rrayst we should enable the SpEL compiler, which increases the performance massively
We want to use the SpEL evaluation context that is used in many places in Membrane now, as the primary expression engine

@predic8
Copy link
Member

predic8 commented Aug 15, 2024

Use SpEL compiler

@t-burch t-burch linked a pull request Aug 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants