Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event cache: handle blocking correctly #3378

Merged
merged 4 commits into from
May 13, 2024

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented May 2, 2024

This should "fix" ignoring/unignoring users, which had regressed likely since the introduction of the event cache.

This is still not perfect: in theory the sliding sync room cache should also be emptied every time we get an ignored/unignored change, but better to wait for #3092 to land, instead of trying to work around it somewhere else.

Part of #3058, should help with element-hq/element-meta#2382 too.

@bnjbvr bnjbvr requested a review from a team as a code owner May 2, 2024 14:54
@bnjbvr bnjbvr requested review from poljar and removed request for a team May 2, 2024 14:54
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.98%. Comparing base (9ef465f) to head (9071542).

Files Patch % Lines
crates/matrix-sdk/src/event_cache/mod.rs 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3378      +/-   ##
==========================================
+ Coverage   82.95%   82.98%   +0.02%     
==========================================
  Files         245      245              
  Lines       25004    25011       +7     
==========================================
+ Hits        20743    20756      +13     
+ Misses       4261     4255       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hywan Hywan requested review from Hywan and removed request for poljar May 2, 2024 15:09
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you insert jokes with my name in the tests so that you're checking whether I've reviewed them or not, that's smart 😏.

@bnjbvr bnjbvr force-pushed the bnjbvr/move-blocking-to-event-cache branch from 83db0f2 to 408c754 Compare May 13, 2024 10:12
@bnjbvr bnjbvr enabled auto-merge (rebase) May 13, 2024 10:13
@bnjbvr bnjbvr force-pushed the bnjbvr/move-blocking-to-event-cache branch from 408c754 to 9071542 Compare May 13, 2024 10:25
@bnjbvr bnjbvr merged commit e709cca into main May 13, 2024
35 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/move-blocking-to-event-cache branch May 13, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants