Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking users is not working anymore as expected #2382

Closed
VolkerJunginger opened this issue Mar 27, 2024 · 5 comments
Closed

Blocking users is not working anymore as expected #2382

VolkerJunginger opened this issue Mar 27, 2024 · 5 comments
Assignees
Labels

Comments

@VolkerJunginger
Copy link
Contributor

Your use case

Blocking users does not work anymore as expected.

  • Blocking a user should hide the users messages: This is not always the case anymore.
  • The timeline seems to "drop" recent messages so the last messages on the screen are from weeks / month ago.
  • Unblocking the user does not bring the timeline back in it's original state. The messages are still from the past & some messages of the blocked user seem still to be hidden.
  • Sending a new message in this room seems to restore the timeline.
  • When a user is blocked the "blocking" call to action is not updated the first time. The button still gives the option to block the user even though I just did that.

The behaviour is quite irrational but seem to be similar on iOS and Android so I suspect this is an SDK issue.

Have you considered any alternatives?

No response

Additional context

No response

@VolkerJunginger VolkerJunginger added T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue labels Mar 27, 2024
@manuroe
Copy link
Member

manuroe commented Mar 27, 2024

Volker is seing this issue on element.io. BWI can see them on their HS.
The behavior is as expected when I test it with my matrix.org account.

@manuroe manuroe removed the X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue label Mar 27, 2024
@manuroe
Copy link
Member

manuroe commented Mar 27, 2024

@kegsay can you share any thoughts on this when you are back?

@manuroe
Copy link
Member

manuroe commented Apr 3, 2024

I tested it again on m.org and it did not work. See the linked rageshake and its sister rageshake.
@bnjbvr raised a suspicious piece of code at https://github.com/matrix-org/matrix-rust-sdk/blob/96a4b06ca69d44cd03f1646b0b78295887c7bb70/crates/matrix-sdk-ui/src/timeline/builder.rs#L212-L225 where the timeline is cleared but not reloaded.

@bnjbvr
Copy link
Member

bnjbvr commented May 2, 2024

matrix-org/matrix-rust-sdk#3378 should help with this.

@manuroe
Copy link
Member

manuroe commented Jul 11, 2024

I just tested it again. It works as expected now. Thanks @bnjbvr !

@manuroe manuroe closed this as completed Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants