Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): LinkedChunk can hold a value for Gaps #3227

Merged
merged 2 commits into from
Mar 18, 2024
Merged

feat(sdk): LinkedChunk can hold a value for Gaps #3227

merged 2 commits into from
Mar 18, 2024

Commits on Mar 18, 2024

  1. feat(sdk): LinkedChunk can hold a value for Gaps. 

    This patch updates `ChunkContent::Gap` to hold a content `U`. Thus,
`Chunk` and LinkedChunk` both get a new generic parameter `U`. Some
methods like `new_gap` or `insert_gap_at` take a new `content: U`
parameter.

This type `RoomEvents` (that uses `LinkedChunk`) is also updated
accordingly.
    @Hywan
    Hywan committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    5591be9 View commit details
    Browse the repository at this point in the history

  2. chore(sdk): Rename T and U in LinkedChunk. 

    This patch renames the generic parameters `T` and `U` to `Item` and
`Gap` for the `LinkedChunk` type and siblings.
    @Hywan
    Hywan committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    7f7d9b8 View commit details
    Browse the repository at this point in the history