feat(sdk): LinkedChunk can hold a value for Gaps
#3227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates `ChunkContent::Gap` to hold a content `U`. Thus, `Chunk` and LinkedChunk` both get a new generic parameter `U`. Some methods like `new_gap` or `insert_gap_at` take a new `content: U` parameter. This type `RoomEvents` (that uses `LinkedChunk`) is also updated accordingly.
Hywan
force-pushed
the
feat-sdk-event-cache-linked-chunk-with-gap-content
branch
from
976b1b2
to
5591be9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3227 +/- ##
=======================================
Coverage 83.70% 83.70%
=======================================
Files 236 236
Lines 24516 24517 +1
=======================================
+ Hits 20520 20521 +1
Misses 3996 3996 ☔ View full report in Codecov by Sentry. |
3 tasks
bnjbvr
approved these changes
Mar 18, 2024
|
It's possible to read the I'm going to rename the generic parameter and merge this PR. |
This patch renames the generic parameters `T` and `U` to `Item` and `Gap` for the `LinkedChunk` type and siblings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates
ChunkContent::Gapto hold a contentU. Thus,ChunkandLinkedChunkboth get a new generic parameterU. Some methods likenew_gaporinsert_gap_attake a newcontent: Uparameter.This type
RoomEvents(that usesLinkedChunk) is also updated accordingly.And because @bnjbvr asked me to do it with Beatbox, I delegate this task to the king of Beatbox: Rythmind.