feat(sdk): Remove FrozenSlidingSyncRoom::timeline
#3092
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes `FrozenSlidingSyncRoom::timeline`, which means we no longer cache on-disk the latest events (up to 10). This feature will be back in a cleaner way with `matrix_sdk_ui::event_graph`. Because `FrozenSlidingSyncRoom::timeline` is removed, we can also remove `SlidingSyncRoom::prev_batch`! It was stored here only to handle this `timeline_queue` when restored back from the cache. The `prev_batch` is already stored correctly in `RoomInfo`, no need to store it here anymore.
poljar
approved these changes
Feb 5, 2024
|
|
||
| assert_eq!(room.room_id(), room_id); | ||
| } | ||
|
|
||
| #[async_test] | ||
| async fn test_prev_batch() { |
There was a problem hiding this comment.
Can't we convert this test to the new field? I'm not sure that we have test for the prev_batch in the sliding sync case otherwise.
Ignore me if we do.
There was a problem hiding this comment.
Hmmm we don't have tests in matrix_sdk_base::sliding_sync for that indeed. I'll write them.
|
To be reopened once we have persistent storage inside the even cache. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes
FrozenSlidingSyncRoom::timeline, which means we nolonger cache on-disk the latest events (up to 10). This feature will be
back in a cleaner way with
matrix_sdk_ui::event_graph.Because
FrozenSlidingSyncRoom::timelineis removed, we can also removeSlidingSyncRoom::prev_batch! It was stored here only to handle thistimeline_queuewhen restored back from the cache. Theprev_batchis already stored correctly in
RoomInfo, no need to store it hereanymore.
SlidingSyncRoomtech debt #3079