Element R: Bump matrix-rust-sdk-crypto-wasm to version 4.0.0 #4021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
changed the title
richvdh
changed the title
richvdh
reviewed
Jan 22, 2024
src/rust-crypto/rust-crypto.ts
Outdated
| await this.outgoingRequestProcessor.makeOutgoingRequest(request); | ||
| } | ||
| // rust layer will take ownership of rustTrackedUser and drops it from the JS side. |
src/rust-crypto/rust-crypto.ts
Outdated
| const userIdentity = await this.olmMachine.getIdentity(rustTrackedUser); | ||
| userIdentity?.free(); |
There was a problem hiding this comment.
This is still required, I think
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
….com/matrix-org/matrix-js-sdk into valere/element-r/bump_bindings_4.0.0
3 tasks
andybalaam
approved these changes
Jan 22, 2024
florianduros
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#26900, element-hq/element-web#26714 and part of element-hq/element-web#26774
init_from_storerenamed asinitFromStoreSide effects of matrix-org/matrix-rust-sdk-crypto-wasm#82
Impacted Methods
shareRoomKeys- Udpated (RoomEncryptor)queryKeysForUsers- Updated (userHasCrossSigningKeys)getMissingSessions- Updated (KeyClaimManager))updateTrackedUsers- Usage was finemigrateOlmSession- no changes usage is finemigrateMegolmSession- no changes usage is fineDeviceListconstructor - no changes usage is finerequestKeyVerification,verificationRequestContent,acceptWithMethod- Ok because is just an intThis change is marked as an internal change (Task), so will not be included in the changelog.