Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element-R: doesn't work in release builds #26714

Closed
richvdh opened this issue Dec 8, 2023 · 5 comments · Fixed by matrix-org/matrix-js-sdk#4021
Closed

Element-R: doesn't work in release builds #26714

richvdh opened this issue Dec 8, 2023 · 5 comments · Fixed by matrix-org/matrix-js-sdk#4021
Assignees
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Element-R-Blocker A blocker for enabling Element R by default Z-Labs

Comments

@richvdh
Copy link
Member

richvdh commented Dec 8, 2023

If you build element-web in release mode, then all the crypto stuff fails with errors like this in the console:

Failed to process events on room !UCnwUWwIKhcpaPTHtR:sw1v.org: Error: Expect an `UserId` instance, received `HI` instead
    at A.exports.__wbindgen_error_new (matrix_sdk_crypto_wasm.js:7299:17)
    at <core::iter::adapters::GenericShunt<I,R> as core::iter::traits::iterator::Iterator>::next::h6cf6c79f3d0e5044 (015888c2:0x3039c5)
    at <alloc::vec::Vec<T> as alloc::vec::spec_from_iter::SpecFromIter<T,I>>::from_iter::h1a067385358156a8 (015888c2:0x23d53c)
    at matrix_sdk_crypto_wasm::machine::user_ids_to_owned_user_ids::hd597160fad090b65 (015888c2:0x2cd655)
    at olmmachine_updateTrackedUsers (015888c2:0x26d0bf)
    at PA.updateTrackedUsers (matrix_sdk_crypto_wasm.js:3454:18)
    at i.onRoomMembership (RoomEncryptor.ts:98:29)
    at r.onRoomMembership (rust-crypto.ts:1441:13)
    at o.emit (events.js:153:5)
    at Me.emit (typed-event-emitter.ts:89:22)

This is due to matrix-org/matrix-rust-sdk-crypto-wasm#51.

@richvdh richvdh added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Element-R Issues affecting the port of Element's crypto layer to Rust Z-Element-R-Blocker A blocker for enabling Element R by default labels Dec 8, 2023
@github-actions github-actions bot added the Z-Labs label Dec 8, 2023
@bseclier
Copy link

Same problem here on a fresh Element install.
Thank you for reporting this issue.

@Hywan
Copy link
Member

Hywan commented Jan 15, 2024

PR is ready. Just need a final polish. Will do it soon.

@Hywan
Copy link
Member

Hywan commented Jan 22, 2024

Can we close this issue since matrix-org/matrix-rust-sdk-crypto-wasm#51 has been closed by matrix-org/matrix-rust-sdk-crypto-wasm#82?

@t3chguy
Copy link
Member

t3chguy commented Jan 22, 2024

@Hywan no since the version of matrix-sdk-crypto-wasm has not yet been updated.

@richvdh
Copy link
Member Author

richvdh commented Jan 23, 2024

This is now fixed!

@richvdh richvdh closed this as completed Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Element-R-Blocker A blocker for enabling Element R by default Z-Labs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants