-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial commit #1588
base: master
Are you sure you want to change the base?
initial commit #1588
Changes from 4 commits
9a3d76c
a3ac5bb
17f5d2d
368f01c
63d53ac
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -1 +1,34 @@ | ||||||||||||||||||||||||
// export const Person = ({ person }) => (); | ||||||||||||||||||||||||
import React from 'react'; | ||||||||||||||||||||||||
|
||||||||||||||||||||||||
export function Person({ person }) { | ||||||||||||||||||||||||
const { | ||||||||||||||||||||||||
name, | ||||||||||||||||||||||||
age, | ||||||||||||||||||||||||
sex, | ||||||||||||||||||||||||
isMarried, | ||||||||||||||||||||||||
partnerName, | ||||||||||||||||||||||||
} = person; | ||||||||||||||||||||||||
|
||||||||||||||||||||||||
const whoIsPartner = sex === 'f' | ||||||||||||||||||||||||
? `${partnerName} is my husband` | ||||||||||||||||||||||||
: `${partnerName} is my wife`; | ||||||||||||||||||||||||
|
||||||||||||||||||||||||
return ( | ||||||||||||||||||||||||
<> | ||||||||||||||||||||||||
<section className="Person"> | ||||||||||||||||||||||||
<h2 className="Person__name">{`My name is ${name}`}</h2> | ||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There is no need to use React fragment here as you already have a container |
||||||||||||||||||||||||
|
||||||||||||||||||||||||
{age | ||||||||||||||||||||||||
&& ( | ||||||||||||||||||||||||
<p className="Person__age"> | ||||||||||||||||||||||||
{`I am ${age}`} | ||||||||||||||||||||||||
</p> | ||||||||||||||||||||||||
)} | ||||||||||||||||||||||||
|
||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||||
<p className="Person__partner"> | ||||||||||||||||||||||||
{isMarried ? `${whoIsPartner}` : 'I am not married'} | ||||||||||||||||||||||||
</p> | ||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||||||||||||||||||||
</section> | ||||||||||||||||||||||||
</> | ||||||||||||||||||||||||
); | ||||||||||||||||||||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.