-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial commit #1588
Open
maksym-mishchanchuk
wants to merge
5
commits into
mate-academy:master
Choose a base branch
from
maksym-mishchanchuk:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
initial commit #1588
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9a3d76c
initial commit
maksym-mishchanchuk a3ac5bb
add props
maksym-mishchanchuk 17f5d2d
add var
maksym-mishchanchuk 368f01c
add var for married person, change jsx in person, delete initial var …
maksym-mishchanchuk 63d53ac
rename var, fixed code style
maksym-mishchanchuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,33 @@ | ||
// export const Person = ({ person }) => (); | ||
import React from 'react'; | ||
|
||
export function Person({ person }) { | ||
const { | ||
name, | ||
age, | ||
sex, | ||
isMarried, | ||
partnerName, | ||
} = person; | ||
|
||
const getPartner = sex === 'f' | ||
? `${partnerName} is my husband` | ||
: `${partnerName} is my wife`; | ||
|
||
return ( | ||
<section className="Person"> | ||
<h2 className="Person__name">{`My name is ${name}`}</h2> | ||
|
||
{age && ( | ||
<p className="Person__age"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess if age is gonna be 0 it's not gonna work correctly, I mean age 0 is not correctly itself, but react will probably just render '0' on the page, so we have to convert it to boolean to make sure it works just fine, we can achieve it by using !! or Boolean |
||
{`I am ${age}`} | ||
</p> | ||
)} | ||
|
||
<p className="Person__partner"> | ||
{isMarried | ||
? `${getPartner}` | ||
: 'I am not married'} | ||
</p> | ||
</section> | ||
); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get sounds like an action, good prefix for function, but not variable
I'd like you to name it as partnerInfo or something like this, you decide