[WIP] #1802: The "three dots" context menu is not closed after unsuccessful licensing from Media Gallery #1826
Conversation
…ssful licensing from Media Gallery - closed context menu after unsuccessful licensing
…ion into 1802-context-menu-not-closed-after-unsuccessful-licensing-from-media-gallery
…ssful licensing from Media Gallery - removed changes in licenseActions.js and created mftf test file
…ssful licensing from Media Gallery - updated mftf test files
|
@joweecaquicla unfortunately, only members of the maintainers team are allowed to assign developers to the pull request |
|
@joweecaquicla unfortunately, only members of the maintainers team are allowed to unassign developers from the pull request |
|
@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B |
There was a problem hiding this comment.
Thanks for the test @joweecaquicla ! Please see my comments
| @@ -9,5 +9,6 @@ | |||
| xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd"> | |||
| <section name="AdminEnhancedMediaGalleryImageActionsSection"> | |||
| <element name="license" type="button" selector="[data-ui-id='action-license']"/> | |||
| <element name="contextMenu" type="block" selector="//div[@class='media-gallery-image']//ul[@class='action-menu _active']//li//a[@class='action-menu-item']"/> | |||
There was a problem hiding this comment.
I'd rename this element to the contextMenuItem and move it to MediaGalleryUi (as this is the module introducing this menu)
| <actionGroup ref="AdminAdobeStockImsPopupSignInFillUserDataActionGroup" stepKey="fillUserCredentials"/> | ||
| <actionGroup ref="AdminAdobeStockImsPopupClickSignInActionGroup" stepKey="clickSignInImsPopup"/> | ||
| <waitForElementVisible selector="{{AdminMessagesSection.errorMessage}}" stepKey="waitErrorMessage"/> | ||
| <dontSeeElement selector="{{AdminEnhancedMediaGalleryImageActionsSection.contextMenu}}" stepKey="verifyContextMenuIsClosed" /> |
There was a problem hiding this comment.
Let's extract this check to AssetAdminMediaGalleryContextMenuOpenedGroup (and place it in the MediaGalleryUi module)
AdobeStockImageAdminUi/Test/Mftf/Test/AdminStandaloneMediaGalleryUnsuccessfulLicensingTest.xml
Show resolved
Hide resolved
AdobeStockImageAdminUi/Test/Mftf/Test/AdminStandaloneMediaGalleryUnsuccessfulLicensingTest.xml
Show resolved
Hide resolved
AdobeStockImageAdminUi/Test/Mftf/Test/AdminStandaloneMediaGalleryUnsuccessfulLicensingTest.xml
Show resolved
Hide resolved
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
…ssful licensing from Media Gallery - modified test and section
|
Hi @joweecaquicla, thank you for your contribution! |
Description (*)
This PR will introduce the MFTF test for the fix on #1802. Link of the fix's PR: magento/magento2#29967
Fixed Issues (if relevant)
Manual testing scenarios (*)