Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "three dots" context menu is not closed after unsuccessful licensing from Media Gallery #1802

Closed
chalov-anton opened this issue Sep 2, 2020 · 1 comment · Fixed by magento/magento2#29967 or #1826
Closed

The "three dots" context menu is not closed after unsuccessful licensing from Media Gallery #1802

chalov-anton opened this issue Sep 2, 2020 · 1 comment · Fixed by magento/magento2#29967 or #1826
Assignees
@joweecaquicla
Labels
bug Something isn't working Priority: P3 May be fixed according to the position in the backlog Severity: S4 A minor problem, annoyance, or technical issue with minimal impact
Milestone
2.1.1

Comments

@chalov-anton
Copy link
Contributor

chalov-anton commented Sep 2, 2020 •
edited
Loading

Preconditions (*)

  1. Install Magento with Adobe Stock Integration
  2. Configured integration in Stores -> Configuration -> Advanced-> System -> Adobe Stock Integration fieldset
  3. Old Media Gallery disabled in Stores -> Configuration -> Advanced-> System -> Media Gallery -> Enable Old Media Gallery - No
  4. Provided API Key (Client ID) . Not provided Client Secret
    client_key
  5. Unlicensed image preview saved to Media Gallery being at the bottom of images

Steps to reproduce (*)

  1. Go to Content - Media Gallery, click Search Adobe Stock
  2. Select the previously saved Unlicensed image
  3. Click "three dots" and select License
  4. Do not click anywhere, observe the behavior

Expected result (*)

The context menu is closed after Login failed... message appears
contextmenu_expected

Actual result (*)

The context menu is NOT closed after Login failed... message appears
contextmenu
context
@m2-assistant
Copy link

m2-assistant bot commented Sep 2, 2020

Hi @chalov-anton. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@engcom-Bravo engcom-Bravo added bug Something isn't working Severity: S4 A minor problem, annoyance, or technical issue with minimal impact labels Sep 2, 2020
@engcom-Bravo engcom-Bravo added this to the 2.1.1 milestone Sep 2, 2020
@sivaschenko sivaschenko added the Priority: P3 May be fixed according to the position in the backlog label Sep 2, 2020
@joweecaquicla joweecaquicla self-assigned this Sep 7, 2020
joweecaquicla pushed a commit to joweecaquicla/adobe-stock-integration that referenced this issue Sep 7, 2020
magento#1802: The three dots context menu is not closed after unsucce…
1cd4495 
…ssful licensing from Media Gallery - closed context menu after unsuccessful licensing
@joweecaquicla joweecaquicla mentioned this issue Sep 7, 2020
Closed
@joweecaquicla joweecaquicla linked a pull request Sep 8, 2020 that will close this issue
#1802: The "three dots" context menu is not closed after unsuccessful licensing from Media Gallery #1816
Closed
joweecaquicla pushed a commit to joweecaquicla/magento2 that referenced this issue Sep 9, 2020
magento/adobe-stock-integration#1802: The three dots context menu is …
dd99a7f 
…not closed after unsuccessful licensing from Media Gallery - modified image.js
@joweecaquicla joweecaquicla mentioned this issue Sep 9, 2020
Merged
4 tasks
@joweecaquicla joweecaquicla self-assigned this Sep 9, 2020
joweecaquicla pushed a commit to joweecaquicla/magento2 that referenced this issue Sep 10, 2020
magento/adobe-stock-integration#1802: The three dots context menu is …
5cc8b4d 
…not closed after unsuccessful licensing from Media Gallery - modified selector
joweecaquicla pushed a commit to joweecaquicla/adobe-stock-integration that referenced this issue Sep 10, 2020
magento#1802: The three dots context menu is not closed after unsucce…
bd29f10 
…ssful licensing from Media Gallery - removed changes in licenseActions.js and created mftf test file
joweecaquicla pushed a commit to joweecaquicla/adobe-stock-integration that referenced this issue Sep 10, 2020
magento#1802: The three dots context menu is not closed after unsucce…
dab12ec 
…ssful licensing from Media Gallery - updated mftf test files
@joweecaquicla joweecaquicla mentioned this issue Sep 10, 2020
Merged
@joweecaquicla joweecaquicla linked a pull request Sep 10, 2020 that will close this issue
[WIP] #1802: The "three dots" context menu is not closed after unsuccessful licensing from Media Gallery #1826
Merged
joweecaquicla pushed a commit to joweecaquicla/magento2 that referenced this issue Sep 10, 2020
magento/adobe-stock-integration#1802: The three dots context menu is …
e392a6b 
…not closed after unsuccessful licensing from Media Gallery - fix merge conflict
joweecaquicla pushed a commit to joweecaquicla/magento2 that referenced this issue Sep 11, 2020
magento/adobe-stock-integration#1802: The three dots context menu is …
1802328 
…not closed after unsuccessful licensing from Media Gallery - added action group and modified sections in media gallery ui mftf
joweecaquicla pushed a commit to joweecaquicla/adobe-stock-integration that referenced this issue Sep 11, 2020
magento#1802: The three dots context menu is not closed after unsucce…
cdadf48 
…ssful licensing from Media Gallery - modified test and section
sivaschenko added a commit that referenced this issue Sep 12, 2020
@sivaschenko
Merge pull request #1826 from joweecaquicla/1802-context-menu-not-clo…
c68f8a2 
…sed-after-unsuccessful-licensing-from-media-gallery

[WIP] #1802: The "three dots" context menu is not closed after unsuccessful licensing from Media Gallery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joweecaquicla joweecaquicla

Labels
bug Something isn't working Priority: P3 May be fixed according to the position in the backlog Severity: S4 A minor problem, annoyance, or technical issue with minimal impact
Projects
None yet
Milestone
2.1.1
4 participants
@sivaschenko @joweecaquicla @chalov-anton @engcom-Bravo