DM-46052: Updates to IsrTaskLSST based on testing on real LATISS and LSSTCam images. #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
force-pushed
the
tickets/DM-46052
branch
from
d81d96c
to
dea8b19
Compare
This adds a saturated column to ensure that the masking code works, although it does add a bit more noise to a few of the test comparisons.
…ure. This tests the functionality of the bad amp filtering code in the crosstalk and ensures that one bad amp doesn't spoil the whole bag.
This also tests that neighbors of saturated regions in parallel overscan are also masked, in an effort to remove the chance of "negative" bias columns.
The crosstalk is assumed to exist and is run in typical bootstrap runs.
In bootstrap mode, no gains will be applied, and the config validation checks explicitly. This greatly simplifies what "bootstrap" mode means for downstream processing.
erykoff
force-pushed
the
tickets/DM-46052
branch
from
4ccab2f
to
7d57287
Compare
|
I reviewed the changes, and I spent some time reviewing test_isrTaskLSST.py. I didn't find anything wrong, although I don't understand all of it well enough. Marking the ticket reviewed. |
craiglagegit
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a number of updates to ip_isr based on testing of the new task and pipelines from DM-45856. Aside from bug fixes and checks of invalid (nan) crosstalk matrix values, there are a large number of updates to the parallel overscan masking to ensure that (a) saturated flats don't get oversubtracted; (b) saturated and unsaturated defect bleeds into the parallel overscan region are handled correctly.
This also takes advantage of crosstalk
fitGainsto apply reasonable gain values when applying crosstalk corrections to bootstrap frames.