Fix protections against double-mask-growth.

lsst · Sep 11, 2024 · d81d96c · d81d96c
1 parent 183ea51
commit d81d96c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/python/lsst/ip/isr/overscan.py b/python/lsst/ip/isr/overscan.py
@@ -266,12 +266,12 @@ def correctOverscan(self, exposure, amp, imageBBox, overscanBBox,
             )
         else:
             median = np.ma.median(np.ma.masked_where(overscanMask, overscanArray))
-            bad = np.where(np.abs(overscanArray - median) > self.config.maxDeviation)
+            bad = np.where((np.abs(overscanArray - median) > self.config.maxDeviation) & (~overscanMask))
             # Mark the bad pixels as BAD.
             overscanImage.mask.array[bad] = overscanImage.mask.getPlaneBitMask("BAD")
 
             # Check for completely masked row/column.
-            if maskedRowColumnGrowSize > 0:
+            if maskedRowColumnGrowSize > 0 and len(bad) > 0:
                 if isTransposed:
                     axis = 0
                     nComp = overscanArray.shape[0]

diff --git a/tests/test_overscanCorrection.py b/tests/test_overscanCorrection.py
@@ -543,6 +543,7 @@ def test_bleedParallelOverscanCorrection(self):
 
                     configParallel = ipIsr.overscan.ParallelOverscanCorrectionTask.ConfigClass()
                     configParallel.parallelOverscanMaskGrowSize = 1
+                    configParallel.parallelOverscanMaskedColumnGrowSize = 0
                     configParallel.fitType = fitType
 
                     parallelOverscanTask = ipIsr.overscan.ParallelOverscanCorrectionTask(