Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46401: fix support for multiple instruments (etc) in where expressions #1083

Merged
merged 3 commits into from
Sep 23, 2024

Commits on Sep 19, 2024

  1. Don't flag 'instrument=X' expressions as needing an instrument.

    We want to flag a constraint like 'visit=X' with no instrument as
    needing an instrument constraint, or (if one is available) use the
    instrument from the butler's default data ID.  But we were also
    flagging constraints like 'instrument=X', and while that on its own
    provides the needed constraint, 'instrument=X OR instrument=Y' does
    not, and hence always failed.
    TallJimbo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e92b0e2 View commit details
    Browse the repository at this point in the history
  2. Allow queries with OR or IN constraints on governor dimensions.

    Instead of requiring a new-query-system WHERE constraint to lock down
    the (e.g.) instrument to a single value in order to allow a dependent
    value (e.g. detector) to appear, we now just check that instrument
    appears somewhere in the expression, since that'd catch the most likely
    mistake of leaving the instrument out entirely (or assuming incorrectly
    that a default would be available).
    TallJimbo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    42be712 View commit details
    Browse the repository at this point in the history
  3. Add changelog entry.

    TallJimbo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    622876d View commit details
    Browse the repository at this point in the history