DM-46401: fix support for multiple instruments (etc) in where expressions #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1083 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 360 360
Lines 47061 47077 +16
Branches 9661 9664 +3
=======================================
+ Hits 42213 42228 +15
Misses 3480 3480
- Partials 1368 1369 +1 ☔ View full report in Codecov by Sentry. |
We want to flag a constraint like 'visit=X' with no instrument as needing an instrument constraint, or (if one is available) use the instrument from the butler's default data ID. But we were also flagging constraints like 'instrument=X', and while that on its own provides the needed constraint, 'instrument=X OR instrument=Y' does not, and hence always failed.
Instead of requiring a new-query-system WHERE constraint to lock down the (e.g.) instrument to a single value in order to allow a dependent value (e.g. detector) to appear, we now just check that instrument appears somewhere in the expression, since that'd catch the most likely mistake of leaving the instrument out entirely (or assuming incorrectly that a default would be available).
TallJimbo
force-pushed
the
tickets/DM-46401
branch
from
7b2be8a
to
622876d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changesconfigs/old_dimensions