Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read file as Buffer, process lines as strings. #493

Closed
wants to merge 1 commit into from

Conversation

bruce-one
Copy link

@bruce-one bruce-one commented Feb 22, 2017

Read the file as a Buffer, then process lines as strings.

This avoids/mitigates maximum string length issues in V8.

Fixes #389

(Just if helpful :-) )

This avoids/mitigates maximum string length issues in V8.
@JamesMGreene
Copy link
Contributor

I'm thinking existing PR #463 might be a better implementation of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants