-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read file as Buffer to mitigate V8's 256MB max string size #6
Comments
This looks like a better implementation to consider: louischatriot/nedb#463 |
Seems like a symmetrical method for writing as a stream would also be necessary for the same reason. |
The default |
IMPORTANT NOTE FOR BROWSER COMPATIBILITYAll It is acceptable to have stream-related work in "persistence.js", e.g. listening for events, so long as it
|
For reference: nodejs/node#3175 |
Read file as Buffer, read lines as strings.
Implementation concept can be taken from existing NeDB PR: louischatriot/nedb#493
However, it's not a terribly performant implementation since it is doing things like concatenating an array with itself rather than just pushing new items on to it, so a rewrite is in order.
This would mitigate frustrating issues like the following:
The text was updated successfully, but these errors were encountered: