Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bytearray index out of range error while reading a string. #90

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

pufit
Copy link
Contributor

@pufit pufit commented Jan 7, 2024

Sometimes, a data chunk we are trying to read from CH can exceed a buffer size. If it happens, the data will be split into two parts. In some cases it can happen during the read_varint, so we must fetch the next buffered chunk before finishing the read.

Closes

@itssimon
Copy link

itssimon commented Mar 1, 2024

Just hit this as well in production.

@long2ice This would be another good one to merge and release to make asynch more stable!

@stankudrow
Copy link
Contributor

@pufit , could you possibly provide a detailed example to reproduce the problem?
@itssimon , does this change solve the problem? If so, @long2ice , wouldn't you mind to merge the PR?

@long2ice long2ice merged commit 4a7a06e into long2ice:dev Mar 15, 2024
1 check passed
@long2ice
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants