-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to clear the BufferedReader class from IndexError #94
Merged
long2ice
merged 6 commits into
long2ice:dev
from
stankudrow:fix-buffered-reader-indexerrors
Apr 22, 2024
Merged
Attempt to clear the BufferedReader class from IndexError #94
long2ice
merged 6 commits into
long2ice:dev
from
stankudrow:fix-buffered-reader-indexerrors
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stankudrow
commented
Mar 14, 2024
stankudrow
commented
Mar 14, 2024
stankudrow
commented
Mar 14, 2024
stankudrow
commented
Mar 14, 2024
stankudrow
force-pushed
the
fix-buffered-reader-indexerrors
branch
from
March 17, 2024 12:22
df897ad
to
c5e868a
Compare
stankudrow
commented
Mar 22, 2024
@long2ice , could you have a look at this PR and tell whether it is OK to be merged? |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the following issues:
Continues the PR #90.
The assumption is the case when
len(self.buffer) == self.position
. Currently only two cases were caught:self.buffer=b""
andself.position = 0
- can be when realising the logic of data reading;self.position = len(self.buffer)
-> no reproducible example to lay out.During the investigation, some refactoring stuff was brought.