Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to clear the BufferedReader class from IndexError #94

Merged
merged 6 commits into from
Apr 22, 2024

Conversation

stankudrow
Copy link
Contributor

@stankudrow stankudrow commented Mar 14, 2024

Addresses the following issues:

Continues the PR #90.

The assumption is the case when len(self.buffer) == self.position. Currently only two cases were caught:

  1. self.buffer=b"" and self.position = 0 - can be when realising the logic of data reading;
  2. when self.buffer is not empty and self.position = len(self.buffer) -> no reproducible example to lay out.

During the investigation, some refactoring stuff was brought.

@stankudrow stankudrow marked this pull request as draft March 14, 2024 19:20
@stankudrow stankudrow force-pushed the fix-buffered-reader-indexerrors branch from df897ad to c5e868a Compare March 17, 2024 12:22
@stankudrow stankudrow marked this pull request as ready for review March 18, 2024 06:10
@stankudrow
Copy link
Contributor Author

@long2ice , hello, could you give your opinion on the PR and provide answers to the comments on the test cases described in the docstrings?

Also, could you tell are you planning to release a new version with, at least, this #90 PR to be included?

@stankudrow
Copy link
Contributor Author

@long2ice

@stankudrow
Copy link
Contributor Author

stankudrow commented Apr 22, 2024

@long2ice , could you have a look at this PR and tell whether it is OK to be merged?

@long2ice long2ice merged commit 55cf91f into long2ice:dev Apr 22, 2024
1 check passed
@long2ice
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants