Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I've added a menu to share when long-pressing a video #1222

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

I've added a menu to share when long-pressing a video #1222

wants to merge 2 commits into from

Commits on Oct 1, 2021

  1. I'm working to display share button when long press on a claim lbryi… 

    …o#1133.

 (lbryio#1133)

 So far, I've located the longClick method in the claimadapter.
 I put some Log.d messages to confirm that I can do something when I long press.
 Evreything's working so it looks like I can progress to implement a menu kind of selection for sharing.
    pixel committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    7c0ad62 View commit details
    Browse the repository at this point in the history

  2. I'm working to display share button when long press on a claim lbryi… 

    …o#1133.

 (lbryio#1133)

 So far, I've got it working pretty well. Now, there's quite a few ways to implement a menu after a long press. Signal Messenger has a cool UI for when users long click on a message. But other apps like NewPipe just use a dialog to display other options.

 To keep things simple, I used a popup menu. Now, I added other menu items that you'd see in the FileViewFragment (download, repost, etc.). I added these because only putting "share" in the menu didn't seem like much of a menu.

 "Share" is the only menu item that actually works right now.
    pixel committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    ad31ff7 View commit details
    Browse the repository at this point in the history