I've added a menu to share when long-pressing a video #1222
Conversation
veritaslogix
changed the title
veritaslogix
changed the title
veritaslogix
changed the title
|
Please, rebase your branch so it is a child from commit ca08f7, latest one you pulled from LBRY-android repository. By adding a commit to your master branch and then creating a new branch from it, this PR includes that commit, which is unrelated to the feature you are trying to merge to lbry—android. Then you will need to force-push to your remote. GitHub will likely update automatically this PR. |
|
Okay thanks! So, I've made a new branch to my master branch and rebased this branch to it. Did I understand what you wanted me to do correctly? |
|
Run these commands one by one from master branch: git checkout 09.29.2021-popup_menu And then verify project still builds. Once code has built, run following command, using the id you have setup as your remote (use git remote to see it): git push -f YOUR_REMOTE_HERE 09.29.2021-popup_menu This will update your remote branch and GitHub will also show the forced-push and update the commits, now showing only two. |
…o#1133. (lbryio#1133) So far, I've located the longClick method in the claimadapter. I put some Log.d messages to confirm that I can do something when I long press. Evreything's working so it looks like I can progress to implement a menu kind of selection for sharing.
…o#1133. (lbryio#1133) So far, I've got it working pretty well. Now, there's quite a few ways to implement a menu after a long press. Signal Messenger has a cool UI for when users long click on a message. But other apps like NewPipe just use a dialog to display other options. To keep things simple, I used a popup menu. Now, I added other menu items that you'd see in the FileViewFragment (download, repost, etc.). I added these because only putting "share" in the menu didn't seem like much of a menu. "Share" is the only menu item that actually works right now.
veritaslogix
force-pushed
the
09.29.2021-popup_menu
branch
from
3f7b691
to
ad31ff7
Compare
|
@kekkyojin you are 100% radical. Thank you so much for helping me with that. I just ran those commands they worked perfectly! Thanks! |
|
Please let me know if there's anything you need or if you'd like me to explain my choices in the changes I made. |
Hi there!
I'm working on issue #1133 (#1133)
So far, it's going well. However, there's quite a few ways to implement a menu after a long press. Signal Messenger has a cool UI for when users long click on a message. But other apps like NewPipe just use a dialog to display other options.
To keep things simple, I used a popup menu. I added other menu items that you'd see in the FileViewFragment (download, repost, etc.). I added these because only putting "share" in the menu didn't seem like much of a menu.
(Right now, "Share" is the only menu item that actually works.) Before I keep going, I was looking for some feedback on what I've done so far.
Thanks :)
[PS, I submitted an application to LBRY for an android engineer position on September 9, 2021. This PR is part of my application process.]
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number: 1133
What is the current behavior?: Users have to click on a video to use options like sharing
What is the new behavior?: I added a menu so that when users click on a video they can share it without actually clicking on it
Other information