feat: server-side payload filters #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/sc-253807/payload-filters-round2
branch
from
dbfde41 to
c6fa406
Compare
cwaldren-ld
commented
Sep 3, 2024
| @@ -6,7 +6,6 @@ | |||
| #include "nlohmann/json.hpp" | |||
|
|
|||
| namespace nlohmann { | |||
There was a problem hiding this comment.
Formatter inserted these newlines. The main changes are in Config[Streaming|Polling]Params adding the new filter key param.
cwaldren-ld
force-pushed
the
cw/sc-253807/payload-filters-round2
branch
from
c6fa406 to
a9ffde2
Compare
cwaldren-ld
force-pushed
the
cw/sc-253807/payload-filters-round2
branch
from
a9ffde2 to
c7c254c
Compare
keelerm84
approved these changes
Sep 4, 2024
kinyoklion
reviewed
Sep 4, 2024
| } | ||
| try { | ||
| return regex_search(filter_key, | ||
| boost::regex("^[a-zA-Z0-9][._\\-a-zA-Z0-9]*$")); |
There was a problem hiding this comment.
I think we should try to keep these regexes the same and \w more concisely represents A-Za-z0-9_.
Merged
cwaldren-ld
pushed a commit
that referenced
this pull request
Sep 4, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-cpp-client: 3.6.4</summary> ## [3.6.4](launchdarkly-cpp-client-v3.6.3...launchdarkly-cpp-client-v3.6.4) (2024-09-04) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-internal bumped from 0.8.1 to 0.8.2 * launchdarkly-cpp-common bumped from 1.7.0 to 1.8.0 </details> <details><summary>launchdarkly-cpp-common: 1.8.0</summary> ## [1.8.0](launchdarkly-cpp-common-v1.7.0...launchdarkly-cpp-common-v1.8.0) (2024-09-04) ### Features * server-side payload filters ([#435](#435)) ([aaff0b8](aaff0b8)) </details> <details><summary>launchdarkly-cpp-internal: 0.8.2</summary> ## [0.8.2](launchdarkly-cpp-internal-v0.8.1...launchdarkly-cpp-internal-v0.8.2) (2024-09-04) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-common bumped from 1.7.0 to 1.8.0 </details> <details><summary>launchdarkly-cpp-server: 3.6.0</summary> ## [3.6.0](launchdarkly-cpp-server-v3.5.3...launchdarkly-cpp-server-v3.6.0) (2024-09-04) ### Features * server-side payload filters ([#435](#435)) ([aaff0b8](aaff0b8)) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-internal bumped from 0.8.1 to 0.8.2 * launchdarkly-cpp-common bumped from 1.7.0 to 1.8.0 </details> <details><summary>launchdarkly-cpp-server-redis-source: 2.1.12</summary> ## [2.1.12](launchdarkly-cpp-server-redis-source-v2.1.11...launchdarkly-cpp-server-redis-source-v2.1.12) (2024-09-04) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-server bumped from 3.5.3 to 3.6.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces Payload Filters to the C++ Server-Side SDK. The filter key can be configured individually on the Streaming or Polling data sources.
If an invalid key is provided (empty or not matching regex), a runtime error will be logged at the time of data source construction. The SDK will then request an unfiltered environment as a failsafe.
e2e testing: