ci: upgrade googletest #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #236513: Investigate DEADLYSIGNAL in CI. |
cwaldren-ld
force-pushed
the
cw/sc-236513/googletest-upgrade
branch
from
8f17a19 to
46845e5
Compare
|
So, looks like there was one failure where the runner ran for 1+ hour out of 7 runs in the This could be a total coincidence, but it does seem like a better failure rate than 1 out of 2 or 3. |
kinyoklion
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades googletest to a much more recent commit. The intention is to see if it helps with the
DEADLYSIGNALissue that has been plaguing this repo's CI for the last couple weeks.Underlying theory is that possibly there is some incompatibilitiy between the old googletest and gcc.