refactor: various client SDK lints #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
commented
Nov 21, 2023
| @@ -30,14 +30,14 @@ using launchdarkly::client_side::data_sources::DataSourceStatus; | |||
| using launchdarkly::config::shared::built::DataSourceConfig; | |||
| using launchdarkly::config::shared::built::HttpProperties; | |||
|
|
|||
There was a problem hiding this comment.
Removing redundant namespace + formatting
cwaldren-ld
commented
Nov 21, 2023
| @@ -1,33 +1,32 @@ | |||
| #pragma once | |||
|
|
|||
There was a problem hiding this comment.
Sorting include paths according to our standard from most specific to least specific.
cwaldren-ld
commented
Nov 21, 2023
| @@ -0,0 +1,20 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
Copying this from internal lib, as it will be removed when the server-side SDK is introduced and we don't want to port over the client immediately.
cwaldren-ld
commented
Nov 21, 2023
| @@ -1,14 +1,13 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
Sort includes + remove redundant namespace
cwaldren-ld
commented
Nov 21, 2023
| @@ -1,24 +1,24 @@ | |||
| #pragma once | |||
|
|
|||
cwaldren-ld
commented
Nov 21, 2023
| @@ -1,10 +1,8 @@ | |||
| #pragma once | |||
|
|
|||
| #include <chrono> | |||
There was a problem hiding this comment.
Remove useless using and sort includes + remove redundant namespaces
cwaldren-ld
force-pushed
the
cw/client-updates
branch
from
a0a8712 to
0e07eaa
Compare
|
Mac CI is expected to fail due to a known issue with the updated boost libraries. |
keelerm84
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mostly removing a bunch of redundant namespace qualifiers + formatting changes in the client SDK, which I addressed while building the Redis integration.
We can merge these directly to main instead to make the Redis PR cleaner.