chore: set OpenSSL root dir properly in CI #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
commented
Nov 4, 2023
| @@ -40,7 +40,7 @@ runs: | |||
| shell: bash | |||
| run: | | |||
| brew install boost | |||
| echo "BOOST_ROOT=$(boost --prefix boost@1.82)" >> $GITHUB_OUTPUT | |||
| echo "BOOST_ROOT=$(brew --prefix boost)" >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
This is just wrong, fixing in this PR since it's in the same vein.
cwaldren-ld
force-pushed
the
cw/openssl-root-dir
branch
from
fc92b4a to
aa24985
Compare
kinyoklion
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our "install OpenSSL" CI step, I hadn't properly setup the "return values" - setting the
OPENSSL_ROOT_DIRproperly.The builds still mostly worked, but were fragile. This is due to CMake's find modules finding them anyways. Except when they don't!