Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix OpenSSL root dir #285

Closed
wants to merge 3 commits into from
Closed

chore: fix OpenSSL root dir #285

wants to merge 3 commits into from

Conversation

cwaldren-ld
Copy link
Contributor

@cwaldren-ld cwaldren-ld commented Nov 3, 2023

We seem to be getting Boost 1.82 or 1.83 luck of the draw on Mac runners. Unfortunately, 1.83 has a breaking change - Boost.url is no longer header-only.

The existing script was wrong anyways, since it was assuming brew install boost would get 1.82.

@cwaldren-ld cwaldren-ld marked this pull request as ready for review November 3, 2023 23:40
@cwaldren-ld cwaldren-ld requested a review from a team November 3, 2023 23:40
@cwaldren-ld
Copy link
Contributor Author

Ah, right. Brew only keeps the latest version of boost 😢 .

@cwaldren-ld
Copy link
Contributor Author

Turns out the openssl action wasn't actually setting OPENSSL_ROOT_DIR this whole time - it just happened to work because CMake's find module was good enough.

@cwaldren-ld cwaldren-ld changed the title chore: pin boost 1.82 on mac chore: fix OpenSSL root dir Nov 4, 2023
@cwaldren-ld cwaldren-ld closed this Nov 4, 2023
@cwaldren-ld cwaldren-ld deleted the cw/boost-1.82-on-mac branch November 4, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant