chore: limit commit-search-depth to 10 for server-side package #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears release-please is looking far back in history when determining the release version of the server package. During this search, it also appears to be running into a SSE commit that didn't use conventional commit formatting.
Now, it's unclear if this is connected - but it might be making release-please think that an SSE bump is required.
My theory is that by limiting to 10 commits (not sure how low this could be - 0?) we can eliminate the issue. This should be ok since we know for a fact no conventional commits have happened to SSE client that would affect the server.
This all feels rather unintuitive though. I'd like to keep digging but this is becoming a time sink.