Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cb changes 20241121 #11051

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Cb changes 20241121 #11051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c65cc0e
[core] add global spelling
tiff Nov 21, 2024
1fde36e
[de] improve rules
tiff Nov 21, 2024
9fcd35e
[de] add spelling
tiff Nov 21, 2024
ccd8620
[en] improve rules
tiff Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions languagetool-core/src/main/resources/org/languagetool/resource/disambiguation-global.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,14 @@ Copyright (C) 2021 Jaume Ortolà
</pattern>
<disambig action="ignore_spelling"/>
</rule>

<rule name="WPA2" id="WPA2">
<pattern>
<token regexp="yes" case_sensitive="yes">WPA[1-3]</token>
</pattern>
<disambig action="ignore_spelling"/>
</rule>

<rulegroup id="GLOBAL_IGNORE_FUNCTION_NAMES" name="ignore function names">
<!-- e.g. file.setName() -->
<rule>
Expand Down
23 changes: 23 additions & 0 deletions languagetool-core/src/main/resources/org/languagetool/resource/spelling_global.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12122,6 +12122,7 @@ Subaru WRX STI
Subaru BRZ
Robert Heinlein
Robert Anson Heinlein
Starship
Starship Troopers
Killah Priest
Ryan Blaney
Expand Down Expand Up @@ -26749,6 +26750,28 @@ Pete Hegseth
Hegseth
Omar Marmoush
Greg Kinnear
John Thune
Chris Wright
Joint Chiefs of Staff
Hugo Ekitiké
Opel Astra Electric
Opel Corsa Electric
Vauxhall Astra Electric
Vauxhall Corsa Electric
Acqua Panna
Mini Cooper E
MINI Cooper E
Comment on lines +26762 to +26763
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Standardize MINI brand capitalization

There's an inconsistency in the capitalization of the MINI brand name:

  • Line 26762: "Mini Cooper E"
  • Line 26763: "MINI Cooper E"

According to the brand guidelines, MINI should be capitalized.

-Mini Cooper E
+MINI Cooper E
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Mini Cooper E
MINI Cooper E
MINI Cooper E
MINI Cooper E

WPA2
Speedometer
Suzuki Vitara
Suzuki E-Vitara
Iris Plus Graphics
Fabian Hürzeler
Howard Lutnick
Scott Bessent
Lucid Air
Sean Duffy
Marc Rowan
Eliot Ness
Nicholas Negroponte
London Sinfonietta
Expand Down
1 change: 1 addition & 0 deletions ...agetool-language-modules/de/src/main/resources/org/languagetool/resource/de/compounds.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11603,6 +11603,7 @@ Chagos-Archipel*
Drive-by-Shooting*
Drive-by-Shootings*
SIM-Lock*
Hand-Fuß-Mund-Krankheit*
Reenactor-Messe$
Reenactor-Messen$
Bundesliga-Start$
Expand Down
5 changes: 5 additions & 0 deletions ...l-language-modules/de/src/main/resources/org/languagetool/resource/de/hunspell/ignore.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243818,6 +243818,11 @@ Martijn/S #name
Luchenko/S
Mutares #name
Abhijith/S #name
Abijith/S #name
Ekitiké/S #name
WPA #abk
Embedded #eng
VAT #abk
Madsack/S #name
Hegseth/S #name
Lugeder/S
Expand Down
18 changes: 18 additions & 0 deletions ...language-modules/de/src/main/resources/org/languagetool/resource/de/hunspell/spelling.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65272,6 +65272,24 @@ Techunternehmerinnen
Lupinenkaffee/S
Privatdetektei
SIM-Lock/S
superpragmatisch/A
regierungsoffiziell/A
umsatzfördernd/A
gemeinschaftsfördernd/A
projektfördernd/A
muskelfördernd/A
muskelaufbaufördernd/A
Downsizing/S #eng
sanktionsstranguliert/A
klimawahnsinnig/A
Expresszugverbindung
Expresszugverbindungen
Expresszug/S
über_interpretieren
unter_interpretieren
teilzufrieden/A
dividendenlos/A
rein_trainieren
Comment on lines +65275 to +65292
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Alphabetical ordering is not maintained in this section

The entries are not properly alphabetically ordered. The word "superpragmatisch" should come after "umsatzfördernd" based on alphabetical order. Current order:

  • SIM-Lock/S
  • superpragmatisch/A
  • regierungsoffiziell/A
  • umsatzfördernd/A
  • gemeinschaftsfördernd/A
  • projektfördernd/A
  • muskelfördernd/A

Correct alphabetical order should be:

  • SIM-Lock/S
  • regierungsoffiziell/A
  • superpragmatisch/A
  • umsatzfördernd/A
  • gemeinschaftsfördernd/A
  • projektfördernd/A
  • muskelfördernd/A
🔗 Analysis chain

Verify alphabetical ordering with surrounding entries

While the new entries appear to be alphabetically ordered among themselves, we should verify they maintain proper ordering with surrounding entries in the file.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if the new entries maintain alphabetical ordering with surrounding context
# Get 5 lines before and after the changed section for context

rg -B 5 -A 5 "^superpragmatisch/A" "languagetool-language-modules/de/src/main/resources/org/languagetool/resource/de/hunspell/spelling.txt"

Length of output: 337

versorgungsmedizinisch/A
Psychopharmakotherapie/N
wabbelnd/A
Expand Down
7 changes: 5 additions & 2 deletions ...anguage-modules/de/src/main/resources/org/languagetool/resource/de/multitoken-suggest.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3117,8 +3117,11 @@ Pete Hegseth/S #name
Elise Stefanik/S #name
Red Sweep/S
Blue Sweep/S
Sexiest Man Alive
Sexiest Woman Alive
Sexiest Man Alive/S #eng
Sexiest Woman Alive/S #eng
Hugo Ekitiké/S #name
Embedded Systems #eng
Duo Infernale
Ingvar Kamprad/S #name
Masel tov
masel tov
Expand Down
2 changes: 2 additions & 0 deletions languagetool-language-modules/de/src/main/resources/org/languagetool/rules/de/replace.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,6 +812,8 @@ Nannies=Nannys Nach den offiziellen Rechtschreibanpassungen von 2024 wird der Pl
Rallies=Rallys Nach den offiziellen Rechtschreibanpassungen von 2024 wird der Plural von Substantiven aus dem Englischen, die auf -y enden, im Deutschen auf "-ys" gebildet (Ausnahme: Eigennamen) "-ys" gebildet (Ausnahme: Eigennamen)
Fettarmekost=fettarme Kost
Gutelaune=gute Laune
Hugo Ekitike=Hugo Ekitiké
Hugo Ekitikes=Hugo Ekitikés
Lugenbrief=Lügenbrief
Lugenbriefe=Lügenbriefe
Lugenbriefs=Lügenbriefs
Expand Down
1 change: 1 addition & 0 deletions languagetool-language-modules/en/src/main/resources/org/languagetool/resource/en/added.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1064,6 +1064,7 @@ Gholdengo Gholdengo NNP
Wo-Chien Wo-Chien NNP
Chien-Pao Chien-Pao NNP
Abhijith Abhijith NNP
Abijith Abijith NNP
Ting-Lu Ting-Lu NNP
Chi-Yu Chi-Yu NNP
Koraidon Koraidon NNP
Expand Down
4 changes: 4 additions & 0 deletions ...l-language-modules/en/src/main/resources/org/languagetool/resource/en/hunspell/ignore.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10945,6 +10945,10 @@ shortlinks
zh
unlogged
Abhijith
Abijith
WPA
OpEx
CapEx
IC
ICs
PDE
Expand Down
3 changes: 3 additions & 0 deletions ...language-modules/en/src/main/resources/org/languagetool/resource/en/hunspell/spelling.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,6 +538,9 @@ bioorganometallic
organometallic
organometallics
victimhood
culturewise
unintrusive
unintrusively
UV-degradable
oxy-degradable
bio-degradable
Expand Down
1 change: 1 addition & 0 deletions languagetool-language-modules/en/src/main/resources/org/languagetool/rules/en/diacritics.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1394,6 +1394,7 @@ Remy Cointreau=Rémy Cointreau
Antonio Costa=António Costa
Port de Pollenca=Port de Pollença
Ruben Vargas=Rubén Vargas
Hugo Ekitike=Hugo Ekitiké
Vincent Bollore=Vincent Bolloré
Alvaro Morata=Álvaro Morata
La Defense Arena=La Défense Arena
Expand Down
2 changes: 1 addition & 1 deletion languagetool-language-modules/en/src/main/resources/org/languagetool/rules/en/grammar.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72199,7 +72199,7 @@ USA
<antipattern>
<token regexp="yes">an?</token>
<token>honors</token>
<token>thesis</token>
<token regexp="yes">thesis|major|student|graduate|class|degree|program|diploma|course</token>
</antipattern>
<antipattern>
<token>_</token>
Expand Down