Burrow #553
Open
Burrow #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfresh2
reviewed
Aug 8, 2023
Comment on lines
+198
to
+200
| val slot = player.hotbarSlots.firstItem<ItemBlock, Slot> { | ||
| it.item is ItemBlock && it.item.block.let { b -> b == Blocks.OBSIDIAN || b == Blocks.ENDER_CHEST } | ||
| } ?: return@safeListener |
There was a problem hiding this comment.
Let's add a setting for hotbar spoof and use the HotbarManager.spoofHotbar helper methods instead of doing it all manually.
I think it should work as it sends packets immediately unlike the PlayerPacketManager (which I don't think will work here as packet ordering and timing is specific)
Also let's check the main and offhand slots for if they're already holding a block to burrow into. Then no unnecessary swapping packets are sent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull
This pull request aims to make a complete and functional Burrow
Describe how this pull is helpful
This is a reasonably highly requested feature and the Nearby setting makes this very useful for people who can't pvp without cruthes.
Some of the modes will not work on all servers. Don't expect them to.
The defaults are good, and has the Nearby setting automatically enabled. Most users will only have to change the nearby setting.
Additional context
Video