fix: Add missing extra field to ContainerRegistryNode GQL query, mutations
#3208
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jopemachine
changed the title
extra field to ContainerRegistryNode GQL query, mutationsextra field to ContainerRegistryNode GQL query, mutations
lablup-octodog
pushed a commit
that referenced
this pull request
Dec 6, 2024
…mutations (#3208) Backported-from: main (24.12) Backported-to: 24.09 Backport-of: 3208
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
…mutations (#3208) (#3220) Co-authored-by: Gyubong Lee <[email protected]>
6 tasks
yomybaby
pushed a commit
to lablup/backend.ai-webui
that referenced
this pull request
Dec 23, 2024
<!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> ### This PR resolves [#2914](#2914) issue related Core PR: [#3208](lablup/backend.ai#3208) 24.09~24.09.2 : Using `container_registry_nodes` but does not support extra fields. 24.09.3 ~ : support extra field **Changes:** Extra field and argument are supported from version 24.09.3 onwards. Because the arguments for each mutation are not provided as input types, you must create a separate mutation if you want to exclude a specific argument. - Added `extra` field to container registry nodes to support additional JSON metadata - Added JSON editor UI component for managing extra information in container registry editor - Added validation for proper JSON formatting with error messages - Made `value` and `onChange` props optional in BAICodeEditor component - Added translations for JSON format validation messages across all languages **How to test:** 1. move to registry page 2. enter Extra Information to verify that the request succeeds only for valid JSON types. |dark|light| |---|---| ||| **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
|](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/lSyr8xXz1wdXALkJKzVx/2d12bdad-402f-4fdf-a3ca-f3a33c7839a2.png)||){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3209.
Checklist: (if applicable)