feat: support for extra field in registry type #2927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
area:ux
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
ironAiken2
force-pushed
the
feat/support-extra-field-in-registry
branch
from
5009cbd to
6baf617
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.16% (-0.01% 🔻) |
398/7707 |
| 🔴 | Branches | 4.45% (-0.02% 🔻) |
237/5320 |
| 🔴 | Functions | 3.09% (-0% 🔻) |
78/2525 |
| 🔴 | Lines | 5.08% (-0.01% 🔻) |
383/7539 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from d288132
ironAiken2
force-pushed
the
feat/support-extra-field-in-registry
branch
from
6baf617 to
9708910
Compare
ironAiken2
force-pushed
the
feat/support-extra-field-in-registry
branch
from
9708910 to
2725067
Compare
yomybaby
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Please add a condition for version compatibility.
I got an error below on v24.09.2
No data returned for operation `ContainerRegistryListQuery`, got error(s): Cannot query field 'extra' on type 'ContainerRegistryNode'. See the error `source` property for more information.
2725067 to
ff501e1
Compare
yomybaby
force-pushed
the
feat/support-extra-field-in-registry
branch
from
ff501e1 to
a268421
Compare
ironAiken2
force-pushed
the
feat/support-extra-field-in-registry
branch
3 times, most recently
from
e91b22d to
656249b
Compare
agatha197
approved these changes
Dec 13, 2024
yomybaby
requested changes
Dec 16, 2024
ironAiken2
force-pushed
the
feat/support-extra-field-in-registry
branch
from
656249b to
96d4d8d
Compare
Merge activity
|
<!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> ### This PR resolves [#2914](#2914) issue related Core PR: [#3208](lablup/backend.ai#3208) 24.09~24.09.2 : Using `container_registry_nodes` but does not support extra fields. 24.09.3 ~ : support extra field **Changes:** Extra field and argument are supported from version 24.09.3 onwards. Because the arguments for each mutation are not provided as input types, you must create a separate mutation if you want to exclude a specific argument. - Added `extra` field to container registry nodes to support additional JSON metadata - Added JSON editor UI component for managing extra information in container registry editor - Added validation for proper JSON formatting with error messages - Made `value` and `onChange` props optional in BAICodeEditor component - Added translations for JSON format validation messages across all languages **How to test:** 1. move to registry page 2. enter Extra Information to verify that the request succeeds only for valid JSON types. |dark|light| |---|---| ||| **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
yomybaby
force-pushed
the
feat/support-extra-field-in-registry
branch
from
96d4d8d to
d288132
Compare
|](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/lSyr8xXz1wdXALkJKzVx/2d12bdad-402f-4fdf-a3ca-f3a33c7839a2.png)||){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2914 issue
related Core PR: #3208
24.09~24.09.2 : Using
container_registry_nodesbut does not support extra fields.24.09.3 ~ : support extra field
Changes:
Extra field and argument are supported from version 24.09.3 onwards.
Because the arguments for each mutation are not provided as input types, you must create a separate mutation if you want to exclude a specific argument.
extrafield to container registry nodes to support additional JSON metadatavalueandonChangeprops optional in BAICodeEditor componentHow to test:
Checklist: (if applicable)