feat: Add hot_clients_ips_maxsize, hot_clients_ips_threshold_ratio
#2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
area:docs
This was referenced Apr 30, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 30, 2024
jopemachine
force-pushed
the
04-29-feat_truncate_suspicious_ips_when_it_exceed_the_max_size
branch
from
826f01b to
d075b8e
Compare
jopemachine
force-pushed
the
04-30-Add-suspicious_ips_maxsize-and-suspicious_ips_threshold_ratio
branch
from
9232390 to
f8caa97
Compare
jopemachine
changed the title
suspicious_ips_maxsize, suspicious_ips_threshold_ratiohot_clients_ips_maxsize, hot_clients_ips_threshold_ratio
jopemachine
force-pushed
the
04-30-Add-suspicious_ips_maxsize-and-suspicious_ips_threshold_ratio
branch
from
f8caa97 to
3b56a60
Compare
jopemachine
force-pushed
the
04-29-feat_truncate_suspicious_ips_when_it_exceed_the_max_size
branch
from
646aefb to
fe5dfef
Compare
jopemachine
force-pushed
the
04-30-Add-suspicious_ips_maxsize-and-suspicious_ips_threshold_ratio
branch
from
2914aea to
23133a5
Compare
jopemachine
force-pushed
the
04-29-feat_truncate_suspicious_ips_when_it_exceed_the_max_size
branch
from
fe5dfef to
21403c5
Compare
jopemachine
force-pushed
the
04-30-Add-suspicious_ips_maxsize-and-suspicious_ips_threshold_ratio
branch
from
23133a5 to
1ab8ee7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Define the settings
hot_clients_ips_maxsizeandhot_clients_ips_threshold_ratioin shard_config to allow customization.By adding these key value settings, the existing
anonymous_ratelimitkey-value config path has also been changed.Refer to the 'Command Test' section.
Default value
hot_clients_ips_maxsizehot_clients_ips_threshold_ratioThe
hot_clients_ips_threshold_ratioof 0.8 means that an IP address is classified as a hot client when it reaches 80% or more of therlimit (rate_limit).Please take a look if the values above are sensible, and if not, let me know.
Command test
For example, to set the
anonymous_ratelimitvalue to 10, execute the following command.Checklist: (if applicable)
📚 Documentation preview 📚: https://sorna--2087.org.readthedocs.build/en/2087/
📚 Documentation preview 📚: https://sorna-ko--2087.org.readthedocs.build/ko/2087/