-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Move anonymous_ratelimit
to shared_config
#2067
Draft
jopemachine
wants to merge
4
commits into
04-25-DDoS_prevention_for_anonymous_manager_API_requests
Choose a base branch
from
04-25-move_anonymous_ratelimit_to_shared_config
base: 04-25-DDoS_prevention_for_anonymous_manager_API_requests
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor: Move anonymous_ratelimit
to shared_config
#2067
jopemachine
wants to merge
4
commits into
04-25-DDoS_prevention_for_anonymous_manager_API_requests
from
04-25-move_anonymous_ratelimit_to_shared_config
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
area:docs
Documentations
comp:manager
Related to Manager component
size:XS
~10 LoC
labels
Apr 25, 2024
jopemachine
changed the title
Move
refactor: Move Apr 25, 2024
anonymous_ratelimit
to shared_configanonymous_ratelimit
to shared_config
This was referenced Apr 26, 2024
jopemachine
force-pushed
the
04-25-move_anonymous_ratelimit_to_shared_config
branch
from
April 26, 2024 07:01
11c436d
to
cff9ca4
Compare
jopemachine
changed the base branch from
feat/prevent-ddos
to
04-25-DDoS_prevention_for_anonymous_manager_API_requests
April 26, 2024 07:01
2 tasks
jopemachine
force-pushed
the
04-25-DDoS_prevention_for_anonymous_manager_API_requests
branch
2 times, most recently
from
April 26, 2024 07:49
e0445f9
to
ef09838
Compare
jopemachine
force-pushed
the
04-25-move_anonymous_ratelimit_to_shared_config
branch
from
April 26, 2024 07:49
72e5315
to
6db5684
Compare
jopemachine
force-pushed
the
04-25-DDoS_prevention_for_anonymous_manager_API_requests
branch
from
April 29, 2024 02:42
ef09838
to
b6c4ce6
Compare
jopemachine
force-pushed
the
04-25-move_anonymous_ratelimit_to_shared_config
branch
from
April 29, 2024 02:43
6db5684
to
96e3580
Compare
2 tasks
jopemachine
force-pushed
the
04-25-DDoS_prevention_for_anonymous_manager_API_requests
branch
from
April 30, 2024 02:12
b6c4ce6
to
b54cbe6
Compare
jopemachine
force-pushed
the
04-25-move_anonymous_ratelimit_to_shared_config
branch
from
April 30, 2024 02:12
96e3580
to
cc47a98
Compare
This was referenced Apr 30, 2024
Closed
jopemachine
force-pushed
the
04-25-DDoS_prevention_for_anonymous_manager_API_requests
branch
from
August 5, 2024 04:50
b54cbe6
to
637d4e2
Compare
jopemachine
force-pushed
the
04-25-move_anonymous_ratelimit_to_shared_config
branch
from
August 5, 2024 04:50
cc47a98
to
93f6b02
Compare
jopemachine
force-pushed
the
04-25-DDoS_prevention_for_anonymous_manager_API_requests
branch
from
September 30, 2024 13:29
637d4e2
to
5702f31
Compare
jopemachine
force-pushed
the
04-25-move_anonymous_ratelimit_to_shared_config
branch
from
September 30, 2024 13:48
93f6b02
to
8a127d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
action:on hold
Hold it. Wait for the restart.
area:docs
Documentations
comp:manager
Related to Manager component
size:XS
~10 LoC
type:feature
Add new features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the location of the
anonymous_ratelimit
settings to etcd (local_config
->shared_config
).Command test
For example, to set the anonymous_ratelimit value to 10, execute the following command.
Checklist: (if applicable)
📚 Documentation preview 📚: https://sorna--2067.org.readthedocs.build/en/2067/
📚 Documentation preview 📚: https://sorna-ko--2067.org.readthedocs.build/ko/2067/