fix: Regression of purging user due to fkey constraint of main_access_key
#1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregataa
added
the
skip:changelog
github-actions
bot
added
comp:manager
fregataa
requested review from
achimnol and
kyujin-cho
and removed request for
achimnol
fregataa
requested review from
achimnol and
gee05053
and removed request for
kyujin-cho
5 tasks
achimnol
changed the title
main_access_key
kyujin-cho
approved these changes
Jan 11, 2024
Comment on lines
631
to
638
| user_query = sa.select(UserRow.uuid).where(UserRow.main_access_key == access_key) | ||
| uuid_list: list[str] = [ | ||
| str(raw_uuid) for raw_uuid in (await db_session.scalars(user_query)).all() | ||
| ] | ||
| if uuid_list: | ||
| return DeleteKeyPair( | ||
| False, f"the keypair is used as main access key by user(uuid: {uuid_list})" | ||
| ) |
There was a problem hiding this comment.
Seems like these lines can be simplified by just evaluating result of COUNT(*) query, as the purpose of this block is to check if the user is utilizing this keypair as its main keypair.
fregataa
added a commit
that referenced
this pull request
Jan 11, 2024
…s_key` (#1775) Backported-from: main Backported-to: 23.09
7 tasks
kyujin-cho
pushed a commit
that referenced
this pull request
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up #1761
The
main_access_keyforeign key hasondelete=RESTRICTconstraint, which disallow to delete any user record.Replace the
ondeleteconstraint on themain_access_keyforeign key withSET NULLbecause the existing implementation deleteskeypairrecord before deletinguser.Checklist: (if applicable)