Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: Resolve cycle in alembic migration versions #1840

Merged
merged 1 commit into from
Jan 16, 2024
Merged

hotfix: Resolve cycle in alembic migration versions #1840

merged 1 commit into from
Jan 16, 2024

Conversation

rapsealk
Copy link
Member

This PR is a follow-up of e9b81fc.

Two alembic migration scripts* c5ed277b7f7b by #1775 and 8b2ec7e3d22a by #1835) have dependencies on each other.

backend.ai/src/ai/backend/manager/models/alembic/versions/c5ed277b7f7b_change_main_access_key_ondelete_to_set_.py

Lines 12 to 13 in e9b81fc

revision = "c5ed277b7f7b"
down_revision = "8b2ec7e3d22a"

backend.ai/src/ai/backend/manager/models/alembic/versions/8b2ec7e3d22a_remove_unique_constraint_of_endpoint_url.py

Lines 12 to 13 in e9b81fc

revision = "8b2ec7e3d22a"
down_revision = "c5ed277b7f7b"

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@rapsealk rapsealk added urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE! skip:changelog Make the action workflow to skip towncrier check require:db-migration Automatically set when alembic migrations are added or updated labels Jan 16, 2024
@rapsealk rapsealk added this to the 23.09 milestone Jan 16, 2024
@rapsealk rapsealk self-assigned this Jan 16, 2024
@github-actions github-actions bot added comp:manager Related to Manager component size:XS ~10 LoC labels Jan 16, 2024
fregataa
fregataa approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@fregataa fregataa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The milestone should be 24.03 because 23.09 does not have issues anymore

@fregataa fregataa modified the milestones: 23.09, 24.03 Jan 16, 2024
@fregataa fregataa self-requested a review January 16, 2024 05:04
@kyujin-cho kyujin-cho added this pull request to the merge queue Jan 16, 2024
Merged via the queue into main with commit 91ced47 Jan 16, 2024
41 of 49 checks passed
@kyujin-cho kyujin-cho deleted the hotfix/resolve-detected-cycle-alembic branch January 16, 2024 05:27
kyujin-cho pushed a commit that referenced this pull request Feb 21, 2024
@rapsealk @kyujin-cho
hotfix: Resolve cycle in alembic migration versions (#1840)
8db9da3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyujin-cho kyujin-cho kyujin-cho approved these changes

@fregataa fregataa Awaiting requested review from fregataa

Assignees

@rapsealk rapsealk

Labels
comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:XS ~10 LoC skip:changelog Make the action workflow to skip towncrier check urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE!
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.
3 participants
@rapsealk @kyujin-cho @fregataa